-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Attempt to install jq on all runners #105
Conversation
if: ${{ !startsWith(runner.name, 'GitHub Actions') }} | ||
# # Skip installation on GitHub-hosted runners: | ||
# # https://github.com/orgs/community/discussions/48359#discussioncomment-5323864 | ||
# if: ${{ !startsWith(runner.name, 'GitHub Actions') }} | ||
uses: dcarbone/install-jq-action@v2.1.0 | ||
with: | ||
force: false # Skip install when an existing `jq` is present |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
force: false
means that dcarbone/install-jq-action
does not attempt to install jq
if it already exists. This seems to be sufficient to avoid reinstalling it on GitHub-hosted images, which already have jq installed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that jq is required should be clearly documented though
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
Please do add the curl note to the readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @omus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Let's get this working first and later we can try find a way avoid the install if it's slowing things down.
There was a bug in julia-actions/cache that prevented v1.5.1 from running in jobs that run in containers. This is fixed by julia-actions/cache#105
There was a bug in julia-actions/cache that prevented v1.5.1 from running in jobs that run in containers. This is fixed by julia-actions/cache#105
There was a bug in julia-actions/cache that prevented v1.5.1 from running in jobs that run in containers. This is fixed by julia-actions/cache#105
There was a bug in julia-actions/cache that prevented v1.5.1 from running in jobs that run in containers. This is fixed by julia-actions/cache#105
There was a bug in julia-actions/cache that prevented v1.5.1 from running in jobs that run in containers. This is fixed by julia-actions/cache#105
There was a bug in julia-actions/cache that prevented v1.5.1 from running in jobs that run in containers. This is fixed by julia-actions/cache#105
There was a bug in julia-actions/cache that prevented v1.5.1 from running in jobs that run in containers. This is fixed by julia-actions/cache#105
There was a bug in julia-actions/cache that prevented v1.5.1 from running in jobs that run in containers. This is fixed by julia-actions/cache#105, which is included in v2.0.0.
There was a bug in julia-actions/cache that prevented v1.5.1 from running in jobs that run in containers. This is fixed by julia-actions/cache#105, which is included in v2.0.0.
Fixes: #104
I took the simplest approach, of just removing the check on whether the runner is hosted by GitHub. This seems to work for both non-container and container jobs.
There may be other cases and subtleties that I am missing.
The one caveat is that the container has to have curl installed; this was easy to do but may be worth adding to the readme.