Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid corrupting existing cloned Julia registries #102

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Avoid corrupting existing cloned Julia registries #102

merged 6 commits into from
Jan 16, 2024

Conversation

omus
Copy link
Collaborator

@omus omus commented Jan 15, 2024 •
edited
Loading

Avoid restoring cached registries when the user already has registries in the Julia depot. If we restore the cached registries for cloned repos we end up putting the registry worktree into a dirty state which will cause failures when attempting to update the registry later.

Fixes #94.

@omus omus changed the title Experiment with reproducting issue #94 Experiment with reproducing issue #94 Jan 15, 2024
@omus
Copy link
Collaborator Author

omus commented Jan 15, 2024

Successfully reproduced the failure seen in #94:

Updating registry at `~/.julia/registries/General`
    Updating git-repo `[https://github.com/JuliaRegistries/General.git`](https://github.com/JuliaRegistries/General.git%60)
ERROR: LoadError: GitError(Code:EMERGECONFLICT, Class:Checkout, 12 conflicts prevent checkout)

– https://github.com/julia-actions/cache/actions/runs/7532680593/job/20503798211?pr=102#step:5:17

@omus omus force-pushed the cv/add-julia-registry-test branch 5 times, most recently from 9cefd86 to 4742a07 Compare January 15, 2024 20:41
@omus omus force-pushed the cv/add-julia-registry-test branch from 4742a07 to 8f65c9f Compare January 15, 2024 20:51
@omus omus changed the title Experiment with reproducing issue #94 Avoid corrupting present cloned Julia registries Jan 15, 2024
@omus omus marked this pull request as ready for review January 15, 2024 21:09
@omus omus requested a review from IanButterworth January 15, 2024 21:09
@omus omus changed the title Avoid corrupting present cloned Julia registries Avoid corrupting existing cloned Julia registries Jan 15, 2024
@omus omus mentioned this pull request Jan 15, 2024
Merged
@omus omus mentioned this pull request Jan 15, 2024
Closed
@omus omus merged commit b84ca24 into main Jan 16, 2024
19 checks passed
@omus omus deleted the cv/add-julia-registry-test branch January 16, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanButterworth IanButterworth IanButterworth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error when using cache action after add-julia-registry
2 participants
@omus @IanButterworth