Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pyTooling/Actions from 0.4.6 to 1.0.1 #117

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Bump pyTooling/Actions from 0.4.6 to 1.0.1 #117

merged 2 commits into from
Apr 5, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 3, 2024 •
edited
Loading

Bumps pyTooling/Actions from 0.4.6 to 1.0.1.

Release notes

Sourced from pyTooling/Actions's releases.

v1.0.1

New Features

None

Changes

  • Updated to CodeCov action v4.

Bug Fixes

None

v1.0.0

New Features

  • Added support for Python 3.11, 3.12 and 3.13-alpha.X (see #59)
  • Added support for PyPy 3.8, 3.9 and 3.10.
  • Added support for MSYS2 runtimes: msys, mingw32, mingw64, clang32, clang64 and ucrt64.
    (Before it was MinGW64 only.)
  • Prepared static type checking to support HTML and XML reports as well as artifacts.
    See #41.
  • Wrote a full documentation hosted at GitHub Pages: https://pytooling.github.io/Actions/ generated using BuildTheDocs.
    • Mostly transferred README and other Markdown contents to ReST.
    • Documented all job templates.
      • description
      • inputs
      • secrets
      • outputs
      • usage examples
    • Documented action dependencies.
  • Added test pipeline(s) to verify job templates.
    • Parameters are verified.
    • ArtifactCleanup is verified.
  • Split paths to e.g. unittests into 2 parameters for tests directory (working directory) and the subdirectory for unittests.
  • New first-level outputs from Parameters:
    • python_version - Python version is now a root element and does need to decode params.
    • artifact_names - The list of artifact names is now a root element and does need to decode params. Compared to params it contains more artifact names and is prepared to contain more artifacts and artifact variants like XML vs. HTML.
  • Providing ENVIRONMENT_NAME in unit tests and code coverage collection jobs.
  • The unit testing job template extracts Python packages needed to be installed via pacboy automatically by comparing dependencies with a list of pacboy packages.
  • Added editorconfig and vscode settings file.
  • Added pull-request template.
  • Added dependabot configuration file.

Changes

  • Bumped Python version in MinGW64 from 3.9 to 3.10
  • Bumped default Python version to 3.11
  • Bumped used GitHub Actions to latest versions:
    • actions/checkout@v2 → actions/checkout@v3

... (truncated)

Changelog

Sourced from pyTooling/Actions's changelog.

Releases Management ###################

Releases

r1

.. note:: Upcoming next release based in v1.x.y.

.. attention:: This release introduces breaking changes.

r0

.. todo:: Releases:r0 Needs documentation.

Versions

.. todo:: Releases:Versions Needs documentation.

Branches

.. mermaid::

%%{init: { 'logLevel': 'debug', 'theme': 'neutral', 'gitGraph': {'rotateCommitLabel': false} } }%% gitGraph commit id: "-" branch dev commit id: "B" commit id: "C" checkout main merge dev tag: "v0.4.0" checkout dev commit id: "D" commit id: "E" commit id: "F" checkout main merge dev tag: "v0.5.0"

dev

Development is done on branch dev.

All merge requests need to target this branch.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 3, 2024
@DilumAluthge
Copy link
Member

This is a breaking release. @IanButterworth @omus Can you check to see if this breaks your usage of pyTooling/Actions in this repo's composite action?

After merging this PR, should the next tag of this repo be v2.0.0?

@IanButterworth
Copy link
Member

If this is breaking, why do we need it?

@DilumAluthge
Copy link
Member

DilumAluthge commented Apr 3, 2024 •
edited
Loading

I believe that 0.4.6 is using node16, which causes users to receive non-fatal deprecation warnings.

Personally I think we should stay on node16 for as long as possible (because I don't want to drop support for CentOS 7, and CentOS 7 does not support node20).

But eventually GitHub will force us onto node20 (by making it hard-error if you try to use node16).

@DilumAluthge
Copy link
Member

DilumAluthge commented Apr 3, 2024 •
edited
Loading

https://github.com/pyTooling/Actions/blob/v0.4.6/with-post-step/action.yml:

https://github.com/pyTooling/Actions/blob/adef08d3bdef092282614f3b683897cefae82ee3/with-post-step/action.yml#L39-L40

runs:
  using: 'node16'

@DilumAluthge
Copy link
Member

Ah, 1.0.1 is still using node16: https://github.com/pyTooling/Actions/blob/v1.0.1/with-post-step/action.yml

They merged pyTooling/Actions#76, but I guess they haven't made a new tag yet?

@DilumAluthge
Copy link
Member

pyTooling/Actions@v1.0.1...main

@DilumAluthge
Copy link
Member

Cross-ref #109

@IanButterworth
Copy link
Member

This kind of forced major bump makes me especially happy that we got the caching improvements in as a minor change.

Of course we could maintain version branches and backport things.

@IanButterworth
Copy link
Member

@dependabot rebase

@dependabot
Bump pyTooling/Actions from 0.4.6 to 1.0.1
7656520 
Bumps [pyTooling/Actions](https://github.com/pytooling/actions) from 0.4.6 to 1.0.1.
- [Release notes](https://github.com/pytooling/actions/releases)
- [Changelog](https://github.com/pyTooling/Actions/blob/main/doc/Releases.rst)
- [Commits](pyTooling/Actions@adef08d...60281e0)

---
updated-dependencies:
- dependency-name: pyTooling/Actions
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/pyTooling/Actions-1.0.1 branch from 9f961f3 to 7656520 Compare April 5, 2024 00:14
IanButterworth
IanButterworth reviewed Apr 5, 2024
View reviewed changes
action.yml Outdated Show resolved Hide resolved
IanButterworth
IanButterworth reviewed Apr 5, 2024
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@DilumAluthge
Copy link
Member

Here's the issue I opened upstream for a new release that includes the node20 bump: pyTooling/Actions#77

@IanButterworth IanButterworth merged commit cc87ef3 into main Apr 5, 2024
19 checks passed
@IanButterworth IanButterworth deleted the dependabot/github_actions/pyTooling/Actions-1.0.1 branch April 5, 2024 00:56
@JoshuaLampert JoshuaLampert mentioned this pull request Aug 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanButterworth IanButterworth IanButterworth approved these changes

@omus omus Awaiting requested review from omus

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DilumAluthge @IanButterworth