Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update styling of files documenting rules #1467

Merged
merged 2 commits into from
Oct 28, 2017
Merged

Update styling of files documenting rules #1467

merged 2 commits into from
Oct 28, 2017

Conversation

felicio
Copy link
Contributor

@felicio felicio commented Oct 7, 2017

Increase legibility of negative sentences in counter examples.

ljharb
ljharb approved these changes Oct 8, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Should this change be made consistently in every .md file?

@felicio
Copy link
Contributor Author

felicio commented Oct 9, 2017

I'd definitely agree. At first it might seem as a tooth-picking request, but when I was creating this PR I thought about that the docs are not always read without stress and little things like that could save someone from extra frustration.

The pattern here seems to be in 50+ markdown files where negative verbs (e.g. is/are not) within a paragraph perceived by and followed by a code block should be bold.

If no one jumps in with some clever sed or awk implementations, I could have a look at the rest myself.

@felicio felicio mentioned this pull request Oct 27, 2017
Closed
@felicio felicio changed the title Update jsx-wrap-multilines.md [WIP] Update styling of files documenting rules Oct 27, 2017
@felicio felicio force-pushed the patch-1 branch 2 times, most recently from ec61406 to 94150b2 Compare October 27, 2017 09:33
@felicio
Make negative adverbs above snippets bold
41d9809 
Increase legibility of negative sentences in counter examples.

Closes jsx-eslint#1503
@felicio
Copy link
Contributor Author

felicio commented Oct 27, 2017

I've just squashed and updated the branch with force. Shouldn't it trigger another review request? Nevertheless, I labeled this one as WIP, since it's missing the CONTRIBUTING.md.

ljharb
ljharb approved these changes Oct 28, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 17a7e47 into jsx-eslint:master Oct 28, 2017
@ljharb ljharb changed the title [WIP] Update styling of files documenting rules Update styling of files documenting rules Oct 28, 2017
@dependencies dependencies bot mentioned this pull request Nov 19, 2017
Merged
This was referenced Dec 15, 2017
Open
Closed
This was referenced Feb 2, 2018
Closed
Closed
Closed
Open
Open
Merged
Merged
@dependencies dependencies bot mentioned this pull request Mar 1, 2018
Open
This was referenced Sep 22, 2018
Closed
Closed
Open
Open
Open
This was referenced Sep 11, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felicio @ljharb