Improve memory reservation for insert_entry
#368
Merged
+22
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
core::RefMut::insert_unique
, used byinsert_entry
and others, wewere calling
reserve_entries
before the table insert, which defeatsthe goal of matching capacities. We can't directly call that after table
insert though, because we'll be holding an
OccupiedEntry
that preventslooking at the table itself. Instead, this code path now uses a more
typical doubling growth on the entries
Vec
itself, but still enhancedby considering
MAX_ENTRIES_CAPACITY
as well.