[EventEngine] API contract: Endpoint::Read will provide either an error or data, but never both #38019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or or data, but never both
drfloob
added
the
release notes: yes
ctiller
approved these changes
Oct 29, 2024
ctiller
reviewed
Oct 29, 2024
| /// Status. | ||
| /// executes. Ownership of the buffer is not transferred. Either an error is | ||
| /// passed to the callback (like socket closed), or valid data is available | ||
| /// in the buffer, but never both at the same time. |
There was a problem hiding this comment.
I'd like us to add something along the lines of:
'Implementations that receive valid data must not throw that data away - that is, if valid data is received on the underlying endpoint, a callback will be made with that data available and an ok status.'
There was a problem hiding this comment.
I added this in a followup #38036
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Nov 6, 2024
…or or data, but never both (grpc#38019) Closes grpc#38019 COPYBARA_INTEGRATE_REVIEW=grpc#38019 from drfloob:endpoint-cb-xor 9da1fe3 PiperOrigin-RevId: 691149599
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
…or or data, but never both (grpc#38019) Closes grpc#38019 COPYBARA_INTEGRATE_REVIEW=grpc#38019 from drfloob:endpoint-cb-xor 9da1fe3 PiperOrigin-RevId: 691149599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.