[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6 #32089

apolcyn · 2023-01-12T21:49:22Z

Ruby 3.2 came out at the end of 2022, and rake-compiler-dock just added support in 1.3.0. Ruby 2.6 is now EOL, so stop building pre-compiled targets for it.

Note:

Test coverage is primarily being added in [ruby] testing: Add ruby 3.0/3.1/3.2 unit tests #31991. Besides that, we'll need to follow this up with new distrib tests as well.
I did some cleanup to the Rakefile by removing the if RUBY_PLATFORM =~ /darwin/ - we no longer build packages on macos hosts so there's no need for it.
A hack is made to extconf.rb to work around Regression when upgrading to 1.1.2 or greater: "make install" breaks gRPC native builds on certain macos CI jobs because ginstall corrupts the shared library rake-compiler/rake-compiler#210

…ckages on mac since not used

apolcyn · 2023-01-13T00:05:37Z

Currently macos unit tests are failing (where the ruby extension is built natively on the macos host i.e. not cross-compiled):

<internal:/Users/kbuilder/.rvm/rubies/ruby-3.2.0/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:85:in `require': dlopen(/Volumes/BuildData/tmpfs/altsrc/github/grpc/workspace_ruby_macos_dbg_native/src/ruby/lib/grpc/grpc_c.bundle, 0x0009): tried: '/Volumes/BuildData/tmpfs/altsrc/github/grpc/workspace_ruby_macos_dbg_native/src/ruby/lib/grpc/grpc_c.bundle' (not a mach-o file) - /Volumes/BuildData/tmpfs/altsrc/github/grpc/workspace_ruby_macos_dbg_native/src/ruby/lib/grpc/grpc_c.bundle (LoadError)
	from <internal:/Users/kbuilder/.rvm/rubies/ruby-3.2.0/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from /Volumes/BuildData/tmpfs/altsrc/github/grpc/workspace_ruby_macos_dbg_native/src/ruby/lib/grpc/grpc.rb:22:in `<top (required)>'
	from /Volumes/BuildData/tmpfs/altsrc/github/grpc/workspace_ruby_macos_dbg_native/src/ruby/lib/grpc.rb:19:in `require_relative'
	from /Volumes/BuildData/tmpfs/altsrc/github/grpc/workspace_ruby_macos_dbg_native/src/ruby/lib/grpc.rb:19:in `<top (required)>'
	from <internal:/Users/kbuilder/.rvm/rubies/ruby-3.2.0/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from <internal:/Users/kbuilder/.rvm/rubies/ruby-3.2.0/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from /Volumes/BuildData/tmpfs/altsrc/github/grpc/workspace_ruby_macos_dbg_native/src/ruby/end2end/end2end_common.rb:24:in `<top (required)>'
	from src/ruby/end2end/client_memory_usage_test.rb:17:in `require_relative'
	from src/ruby/end2end/client_memory_usage_test.rb:17:in `<main>'

apolcyn · 2023-01-17T18:17:52Z

The no_native = false experiment caused distrib tests to fail:

+ bundle exec ./distribtest.rb
Success!
+ [[ binary == \s\o\u\r\c\e ]]
++ gem env
++ grep '\- INSTALLATION DIRECTORY'
++ awk '{ print $4 }'
+ INSTALLATION_DIR=/usr/local/rvm/gems/ruby-2.7.0
++ find /usr/local/rvm/gems/ruby-2.7.0 -name grpc_c.so
++ wc -l
+ [[ 5 == 0 ]]
++ find /usr/local/rvm/gems/ruby-2.7.0 -name grpc_c.so -exec ldd '{}' ';'
++ grep -c libruby
A grpc_c.so file in this binary gRPC package is dynamically linked to libruby.
+ LIBRUBY_DEPENDENCY_EXISTS=1
+ [[ 1 != 0 ]]
+ echo 'A grpc_c.so file in this binary gRPC package is dynamically linked to libruby.'
++ find /usr/local/rvm/gems/ruby-2.7.0 -name grpc_c.so -exec ldd '{}' ';'
++ grep -c 'not found'
+ DEPENDENCY_NOT_FOUND=1
+ [[ 1 != 0 ]]
+ echo 'A grpc_c.so file in this binary gRPC package has an non-portable dependency.'
+ '[' 1 '!=' 0 ']'
+ exit 1
A grpc_c.so file in this binary gRPC package has an non-portable dependency.
+ DOCKER_EXIT_CODE=1
+ '[' /tmpfs/src/github/grpc '!=' '' ']'
+ mkdir -p /tmpfs/src/github/grpc
+ cp -r /tmp/tmp.NOZGpssgMg/reports /tmpfs/src/github/grpc
+ '[' '' '!=' '' ']'
+ exit 1

2023-01-17 18:01:57,590 FAILED: distribtest.ruby_linux_x64_stretch_version_ruby_2_7_package_type_binary [ret=1, pid=242254, time=30.8sec]

apolcyn · 2023-01-17T18:18:02Z

The macos issue is not reproducible locally

grpc#32089) [ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6

#32089) (#32157) [ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6

apolcyn · 2023-01-24T19:05:27Z

@johnnyshields FYI this is available in 1.52.pre2 now

grpc#32089) [ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6

#32089) [ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6

apolcyn added 4 commits January 12, 2023 21:05

upgrade rake compiler docker

6f8256c

upgrade docker images

c114501

Upgrade Rakefile to add 3.2 and drop 2.6; remove code for building pa…

ad1d285

…ckages on mac since not used

update docker image versions

0435754

apolcyn added release notes: yes Indicates if PR needs to be in release notes lang/ruby labels Jan 12, 2023

github-actions bot removed the lang/ruby label Jan 12, 2023

remove ruby 2.6 distrib test

69a4f23

grpc-checks bot added per-call-memory/neutral per-channel-memory/neutral bloat/none labels Jan 12, 2023

apolcyn added 2 commits January 12, 2023 22:25

update sha256

b57158b

update rake compiler

1accf47

apolcyn added the lang/ruby label Jan 12, 2023

apolcyn added 2 commits January 13, 2023 06:00

debug statements

983a1d7

temporary pin to 1.1.7

040b9c7

apolcyn force-pushed the ruby_32_support branch from f88d761 to 040b9c7 Compare January 13, 2023 06:02

apolcyn added 4 commits January 13, 2023 06:48

try set no_native = false

74878a2

debug prints

72642bb

dep changes

af3796f

remove explicit installation of bundler

56f1c4a

apolcyn added 6 commits January 17, 2023 18:21

remove experiment

eca241e

remove bundle install hack

7936a08

Merge remote-tracking branch 'origin/master' into ruby_32_support

98fe9b0

add debug logs

0b18fb1

try stripping on dbg build too

614fe51

stop stripping output entirely

69aacbf

apolcyn added 12 commits January 19, 2023 00:07

improve logs; see if ruby 2.7 works

934b0f8

try disabling chained fixups

6ee214c

Add -wl

1b353ab

also check other file

09041c6

more logs

a02fa10

add more logging

ddf187f

Fix log

158a627

Try using copy in rakefile

362882a

add hack

7eb96c8

set workaround for macos

b95f0a7

remove debug logs

183fd0a

revert unnecessary change

b7b7e14

apolcyn mentioned this pull request Jan 19, 2023

Regression when upgrading to 1.1.2 or greater: "make install" breaks gRPC native builds on certain macos CI jobs because ginstall corrupts the shared library rake-compiler/rake-compiler#210

Closed

apolcyn added 2 commits January 19, 2023 20:41

updates

7e5ab91

remove log

63424f6

apolcyn marked this pull request as ready for review January 19, 2023 20:44

apolcyn requested a review from jtattermusch as a code owner January 19, 2023 20:44

apolcyn assigned stanley-cheung Jan 19, 2023

apolcyn requested a review from stanley-cheung January 19, 2023 20:45

stanley-cheung approved these changes Jan 19, 2023

View reviewed changes

apolcyn merged commit c1a4b52 into grpc:master Jan 19, 2023

apolcyn added a commit to apolcyn/grpc that referenced this pull request Jan 19, 2023

[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6 (

60e54f7

grpc#32089) [ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6

This was referenced Jan 20, 2023

Backport "[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6 #32089" to v1.52.x #32157

Merged

[ruby] Undrop ruby 2.6 #32160

Merged

copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Jan 20, 2023

apolcyn added a commit that referenced this pull request Jan 20, 2023

[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6 (

b50ef30

#32089) (#32157) [ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6

XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023

[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6 (

7e573df

grpc#32089) [ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6

wanlin31 pushed a commit that referenced this pull request May 18, 2023

[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6 (

d43fbc2

#32089) [ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6

chadlwilson mentioned this pull request Dec 28, 2023

[ruby] Build/test ruby 3.3 and build native gems with Ruby 3.3 support #35399

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6 #32089

[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6 #32089

apolcyn commented Jan 12, 2023 •

edited

Loading

apolcyn commented Jan 13, 2023

apolcyn commented Jan 17, 2023 •

edited

Loading

apolcyn commented Jan 17, 2023

apolcyn commented Jan 24, 2023

[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6 #32089

[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6 #32089

Conversation

apolcyn commented Jan 12, 2023 • edited Loading

apolcyn commented Jan 13, 2023

apolcyn commented Jan 17, 2023 • edited Loading

apolcyn commented Jan 17, 2023

apolcyn commented Jan 24, 2023

apolcyn commented Jan 12, 2023 •

edited

Loading

apolcyn commented Jan 17, 2023 •

edited

Loading