Introduce IdentifierName:AllowInitialismsInTypeName flag
#4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While default `IdentifierName` behavior is unchanged, this flag allows users to slightly relax the type name validation performed by this check.
|
See this message and the preceding comments for context. Naturally happy to rework the PR to have the flag trigger slightly different behavior, if desired. |
cushon
approved these changes
Oct 30, 2024
benkard
pushed a commit
to benkard/jgvariant
that referenced
this pull request
Nov 20, 2024
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.errorprone:error_prone_core](https://errorprone.info) ([source](https://github.com/google/error-prone)) | | minor | `2.35.1` -> `2.36.0` | | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://github.com/google/error-prone)) | compile | minor | `2.35.1` -> `2.36.0` | --- ### Release Notes <details> <summary>google/error-prone</summary> ### [`v2.36.0`](https://github.com/google/error-prone/releases/tag/v2.36.0): Error Prone 2.36.0 [Compare Source](google/error-prone@v2.35.1...v2.36.0) Changes: - Add new matcher interfaces to `ErrorProneScanner` for AST nodes introduced after Java 11 ([`e5fd194`](google/error-prone@e5fd194)) - Fix compatibility with latest JDK 24 EA builds (google/error-prone@d67bc15) - Check that `--should-stop=ifError=FLOW` is set when using the `-Xplugin` integration ([`e71db1f`](google/error-prone@e71db1f)) New checks: - [`DuplicateBranches`](https://errorprone.info/bugpattern/DuplicateBranches): Discourage conditional expressions and if statements where both branches are the same - [`RedundantControlFlow`](https://errorprone.info/bugpattern/RedundantControlFlow): Reports redundant `continue` statements. Closed issues: [#​4633](google/error-prone#4633), [#​4646](google/error-prone#4646) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While default
IdentifierNamebehavior is unchanged, this flag allowsusers to slightly relax the type name validation performed by this
check.