Skip to content

[2.29.1] JPMS Module metadata was removed #4480

Closed
@ben-manes

Description

I tried upgrading to 2.29.0 / 2.29.1 and it fails due to

> Task :caffeine:compileJava FAILED
/Users/ben/projects/caffeine/caffeine/src/main/java/module-info.java:6: error: module not found: com.google.errorprone.annotations
  requires static com.google.errorprone.annotations;

I tried to follow the previous validation steps:

# 2.28.0: module-info, not in manifest
$ wget -q https://repo1.maven.org/maven2/com/google/errorprone/error_prone_annotations/2.28.0/error_prone_annotations-2.28.0.jar
$ unzip -q error_prone_annotations-2.28.0.jar META-INF/MANIFEST.MF
$ grep Automatic-Module-Name META-INF/MANIFEST.MF
$ unzip -q error_prone_annotations-2.28.0.jar META-INF/versions/9/module-info.class
$ javap -v META-INF/versions/9/module-info.class | grep "open module"
open module com.google.errorprone.annotations@2.28.0

# 2.29.1: no module definition
$ wget -q https://repo1.maven.org/maven2/com/google/errorprone/error_prone_annotations/2.29.1/error_prone_annotations-2.29.1.jar
$ unzip -q error_prone_annotations-2.29.1.jar META-INF/MANIFEST.MF
$ grep Automatic-Module-Name META-INF/MANIFEST.MF
$ unzip -q error_prone_annotations-2.29.1.jar META-INF/versions/9/module-info.class
caution: filename not matched:  META-INF/versions/9/module-info.class

The module-info.java file was removed in Handle static members in inner classes in *CanBeStatic checks (39609bf) which seems unrelated.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions