Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.22.6
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.22.7
Choose a head ref
  • 7 commits
  • 14 files changed
  • 5 contributors

Commits on Aug 14, 2024

  1. [release-branch.go1.22] os: fix Chtimes test flakes

    It appears that some builders (notably, linux-arm) have some additional
    security software installed, which apparently reads the files created by
    tests. As a result, test file atime is changed, making the test fail
    like these:
    
    === RUN   TestChtimesOmit
        ...
        os_test.go:1475: atime mismatch, got: "2024-07-30 18:42:03.450932494 +0000 UTC", want: "2024-07-30 18:42:02.450932494 +0000 UTC"
    
    === RUN   TestChtimes
        ...
        os_test.go:1539: AccessTime didn't go backwards; was=2024-07-31 20:45:53.390326147 +0000 UTC, after=2024-07-31 20:45:53.394326118 +0000 UTC
    
    According to inode(7), atime is changed when more than 0 bytes are read
    from the file. So, one possible solution to these flakes is to make the
    test files empty, so no one can read more than 0 bytes from them.
    
    For #68687
    For #68663
    Fixes #68811
    
    Change-Id: Ib9234567883ef7b16ff8811e3360cd26c2d6bdab
    Reviewed-on: https://go-review.googlesource.com/c/go/+/604315
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Kirill Kolyshkin <kolyshkin@gmail.com>
    Reviewed-by: Robert Griesemer <gri@google.com>
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    Commit-Queue: Ian Lance Taylor <iant@google.com>
    Auto-Submit: Ian Lance Taylor <iant@google.com>
    (cherry picked from commit 84266e1)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/605375
    Reviewed-by: Carlos Amedee <carlos@golang.org>
    kolyshkin authored and cagedmantis committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0a525a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. [release-branch.go1.22] cmd/fix: support go versions with patch release

    Support go version with patch release(e.g. 1.21.0)
    and release candidates(e.g. 1.21rc1)
    when parsing the go version in the fix command
    by using new "go/version" package.
    
    For #62584.
    Fixes #68825.
    
    Change-Id: I0ec16137c7a396c68039d374c770c4021fb54b4e
    GitHub-Last-Rev: 76bced5
    GitHub-Pull-Request: #62586
    Reviewed-on: https://go-review.googlesource.com/c/go/+/527342
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Russ Cox <rsc@golang.org>
    Auto-Submit: Bryan Mills <bcmills@google.com>
    Reviewed-by: Alex Bozhenko <alexbozhenko@gmail.com>
    Reviewed-by: Bryan Mills <bcmills@google.com>
    (cherry picked from commit 7fd62ba)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/603981
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    TryBot-Bypass: Cherry Mui <cherryyz@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Kirill Kolyshkin <kolyshkin@gmail.com>
    alexbozhenko authored and cherrymui committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    676d610 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.22] runtime: on AIX, fix call to _cgo_sys_thread_…

    …create in _rt0_ppc64_aix_lib
    
    The AIX ABI requires allocating parameter save space when calling
    a function, even if the arguments are passed via registers.
    
    gcc sometimes uses this space. In the case of the cgo c-archive
    tests, it clobbered the storage space of argc/argv which prevented
    the test program from running the expected test.
    
    Fixes #68972
    
    Change-Id: I8a267b463b1abb2b37ac85231f6c328f406b7515
    Reviewed-on: https://go-review.googlesource.com/c/go/+/606895
    Reviewed-by: Ian Lance Taylor <iant@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Cherry Mui <cherryyz@google.com>
    Run-TryBot: Paul Murphy <murp@ibm.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/607175
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    pmur authored and cherrymui committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    e87be98 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. [release-branch.go1.22] go/parser: track depth in nested element lists

    Prevents stack exhaustion with extremely deeply nested literal values,
    i.e. field values in structs.
    
    Updates #69138
    Fixes #69142
    Fixes CVE-2024-34155
    
    Change-Id: I2e8e33b44105cc169d7ed1ae83fb56df0c10f1ee
    Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1520
    Reviewed-by: Robert Griesemer <gri@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Russ Cox <rsc@google.com>
    (cherry picked from commit eb1b038c0d01761694e7a735ef87ac9164c6568e)
    Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1561
    Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/611181
    Reviewed-by: Michael Pratt <mpratt@google.com>
    TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    rolandshoemaker authored and gopherbot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b232596 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.22] encoding/gob: cover missed cases when checkin…

    …g ignore depth
    
    This change makes sure that we are properly checking the ignored field
    recursion depth in decIgnoreOpFor consistently. This prevents stack
    exhaustion when attempting to decode a message that contains an
    extremely deeply nested struct which is ignored.
    
    Thanks to Md Sakib Anwar of The Ohio State University (anwar.40@osu.edu)
    for reporting this issue.
    
    Updates #69139
    Fixes #69144
    Fixes CVE-2024-34156
    
    Change-Id: Iacce06be95a5892b3064f1c40fcba2e2567862d6
    Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1440
    Reviewed-by: Russ Cox <rsc@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    (cherry picked from commit f0a11f9b3aaa362cb1d05e095e3c8d421d4f087f)
    Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1580
    Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/611182
    TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    rolandshoemaker authored and gopherbot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    2092294 View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.22] go/build/constraint: add parsing limits

    Limit the size of build constraints that we will parse. This prevents a
    number of stack exhaustions that can be hit when parsing overly complex
    constraints. The imposed limits are unlikely to ever be hit in real
    world usage.
    
    Updates #69141
    Fixes #69148
    Fixes CVE-2024-34158
    
    Change-Id: I38b614bf04caa36eefc6a4350d848588c4cef3c4
    Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1540
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Russ Cox <rsc@google.com>
    (cherry picked from commit 0c74dc9e0da0cf1e12494b514d822b5bebbc9f04)
    Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/1582
    Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/611183
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com>
    rolandshoemaker authored and gopherbot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d4c5381 View commit details
    Browse the repository at this point in the history
  4. [release-branch.go1.22] go1.22.7

    Change-Id: I48927705dee7f707ada7d3536d63da24541102fa
    Reviewed-on: https://go-review.googlesource.com/c/go/+/611197
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Commit-Queue: Gopher Robot <gobot@golang.org>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com>
    gopherbot committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7529d09 View commit details
    Browse the repository at this point in the history
Loading