fix: set multi-weekdays bug about issue-590 #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiXiangFiles
force-pushed
the
fix-issue-590
branch
4 times, most recently
from
5cfa08f to
9a7b185
Compare
XiXiangFiles
force-pushed
the
fix-issue-590
branch
from
9a7b185 to
771b0f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
the root cause of this issue is wrong logic. it should use the weekday to calculate instead of a job.RunCount.
if job.RunCount run over the setting days and it'll encounter an error
Which issue(s) does this PR fix/relate to?
fix #590
List any changes that modify/break current functionality
only fix bugs for schedule. if it executes though all weekdays one time, the behavior will change.
ex: user sets.
.Every(2).Weeks().Monday().Tuesday().At("10:00"). then after executing Monday and Tuesday, the bug will show up. In the next round, after executing on Monday it will wait 2 weeks for execution on TuesdayHave you included tests for your changes?
yes, adjusted existing testing
Did you document any new/modified functionality?
n/a
Notes