Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sdk): Enhance README with improved clarity and developer-friendly examples #3667

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

UTSAVS26
Copy link
Contributor

Added more approachable language and technical examples to help developers understand how to install, configure, and use the Sentry SDK for Python. Clarified instructions around integrations, migration, and contributing. Included additional resources for further learning and support.

The previous README was more formal, and this update makes it more engaging while keeping all necessary technical information intact. This change improves the developer experience by making the documentation more accessible.

…y examples

Added more approachable language and technical examples to help developers understand how to install, configure, and use the Sentry SDK for Python. Clarified instructions around integrations, migration, and contributing. Included additional resources for further learning and support.

The previous README was more formal, and this update makes it more engaging while keeping all necessary technical information intact. This change improves the developer experience by making the documentation more accessible.
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my personal PoV, but this is a tad too cringe.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@UTSAVS26
Copy link
Contributor Author

@cleptric changes made. Please review once again. :)

@sentrivana
Copy link
Contributor

Hey @UTSAVS26, thanks for this, but I'm not sure if I vibe with the changes. It's a bit of a departure from the usual matter-of-fact Sentry tone with occasional dry humor here and there (see e.g. docs or our blog). There's a lot of embellishments and exclamation points. If we could tone that down a bit and still improve the README I'm all in.

README.md Outdated Show resolved Hide resolved
@UTSAVS26
Copy link
Contributor Author

Thanks for your feedback @sentrivana ! I’ll definitely try to tone it down while still making improvements to the README.

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya @UTSAVS26, this sounds much better to me. Left some comments, please apply/address.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@UTSAVS26
Copy link
Contributor Author

Heya @UTSAVS26, this sounds much better to me. Left some comments, please apply/address.

Heya @sentrivana, made necessary changes as asked, feel free to check as per your convenience :)

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sentrivana sentrivana added the Trigger: tests using secrets PR code is safe; run CI label Oct 18, 2024
@sentrivana sentrivana enabled auto-merge (squash) October 18, 2024 11:23
@sentrivana sentrivana merged commit 8d48961 into getsentry:master Oct 18, 2024
137 of 139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants