Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-experimental): Ensure span.finish() works as expected #8947

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix(node-experimental): Ensure span.finish() works as expected #8947

merged 1 commit into from
Sep 6, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 5, 2023

For Sentry.startSpan() API, we need to ensure that when the Sentry Span is finished, we also finish the OTEL Span.

Also adding some tests for these APIs.

@mydea
fix(node-experimental): Ensure span.finish() works as expected
7f7a23b 
For `Sentry.startSpan()` API, we need to ensure that when the Sentry Span is finished, we also finish the OTEL Span.

Also adding some tests for these APIs.
@mydea mydea requested a review from AbhiPrasad September 5, 2023 12:24
@mydea mydea self-assigned this Sep 5, 2023
AbhiPrasad
AbhiPrasad approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever w/ proxy - makes sense to me!

@mydea mydea merged commit 0d49557 into develop Sep 6, 2023
@mydea mydea deleted the fn/potel-startSPan branch September 6, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @AbhiPrasad