Backport bump of System.Configuration.ConfigurationManager
and System.Threading.Tasks.Extensions
#2856
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2673 and #2855 to v7.
See those two PRs for detailed analyses.
CC: @ViktorHofer @AArnott @jacekmlynek
Since you've previously been involved in package vs framework references.
Additional details:
In #2122 (comment) I experimented with referencing 6.9.0 and 6.10.0 as nuget packages from a net47 project and then comparing detailed MSBuild logs.
It showed how 6.10.0 no longer had conflicts between package and framework assemblies.
Doing that same comparison between
main
and this PR, the MSBuild log is now down from 90 to 0 occurrences ofand now skips the running the build task
AddFacadesToReferences
Comparing the
bin/
folder of a net47 project that references Fluent Assertions via a nuget packages.main:
PR:
IMPORTANT
./build.sh --target spellcheck
or.\build.ps1 --target spellcheck
before pushing and check the good outcome