Correct null handling when using a custom comparer #2489

MartinDemberger · 2023-11-27T21:28:57Z

Currently a custom comparer surpresses the BeEquivalent compare with a nullable struct property against a expected null value.
This change doesn't use the custom comparer for a struct with a expected null.

#2480

IMPORTANT

If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
The code complies with the Coding Guidelines for C#.
The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
- Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

…stom comparer. #2480

github-actions · 2023-11-27T21:36:22Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register at Qodana Cloud and configure the action
Use GitHub Code Scanning with Qodana
Host Qodana report at GitHub Pages
Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

docs/_pages/releases.md

Src/FluentAssertions/Equivalency/Steps/EqualityComparerEquivalencyStep.cs

…he expectation. Also added more tests for all cases.

Tests/FluentAssertions.Equivalency.Specs/ExtensibilitySpecs.cs

MartinDemberger · 2023-12-01T16:36:19Z

Can anyone help me? I don't understand the error message in Qodana.

IT-VBFK · 2023-12-01T21:03:15Z

Try rebase at the current develop and push again

From my understanding, a qodana report without a summary (like here) happens, if the default branch (here develop) moves forward while the PR is not onto this branch.

github-actions · 2023-12-01T21:26:44Z

Qodana for .NET

4 new problems were found

Inspection name	Severity	Problems
`Possible 'System.NullReferenceException'`	🔶 Warning	2
`Auto-property accessor is never used (private accessibility)`	🔶 Warning	2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

Tests/FluentAssertions.Equivalency.Specs/ExtensibilitySpecs.cs

Src/FluentAssertions/Equivalency/Steps/EqualityComparerEquivalencyStep.cs

coveralls · 2023-12-09T18:25:43Z

Pull Request Test Coverage Report for Build 7357619396

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.001%) to 97.464%

Files with Coverage Reduction	New Missed Lines	%
Src/FluentAssertions/Execution/DefaultAssertionStrategy.cs	4	20.0%

Totals
Change from base Build 7260721275:	0.001%
Covered Lines:	11746
Relevant Lines:	11930

💛 - Coveralls

docs/_pages/releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

Src/FluentAssertions/Equivalency/Steps/EqualityComparerEquivalencyStep.cs

Co-authored-by: ITaluone <44049228+ITaluone@users.noreply.github.com>

github-actions · 2023-12-15T13:32:07Z

Qodana for .NET

58 new problems were found

Inspection name	Severity	Problems
`Redundant type declaration body`	🔶 Warning	51
`Redundant using directive`	🔶 Warning	7

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

ITaluone · 2023-12-18T14:16:36Z

A few qodana issues are left :)

…2489) * Correct null handling when having a nullable struct propertywith a custom comparer. fluentassertions#2480 * Release notes added * typo corrected * Removed the check for only value types and added the null check for the expectation. Also added more tests for all cases. * typo corrected * Warnings solved * Added a comment for the changed code * Comment cleaned * Update docs/_pages/releases.md Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com> * Typo corrected Co-authored-by: ITaluone <44049228+ITaluone@users.noreply.github.com> * Corrected Qodana issues * cleanups --------- Co-authored-by: Martin Demberger <martin.demberger@root-nine.de> Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com> Co-authored-by: ITaluone <44049228+ITaluone@users.noreply.github.com> Co-authored-by: Jonas Nyrup <jnyrup@gmail.com>

* Correct null handling when having a nullable struct propertywith a custom comparer. #2480 * Release notes added * typo corrected * Removed the check for only value types and added the null check for the expectation. Also added more tests for all cases. * typo corrected * Warnings solved * Added a comment for the changed code * Comment cleaned * Update docs/_pages/releases.md Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com> * Typo corrected Co-authored-by: ITaluone <44049228+ITaluone@users.noreply.github.com> * Corrected Qodana issues * cleanups --------- Co-authored-by: Martin Demberger <martin.demberger@root-nine.de> Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com> Co-authored-by: ITaluone <44049228+ITaluone@users.noreply.github.com> Co-authored-by: Jonas Nyrup <jnyrup@gmail.com>

MartinDembergerR9 added 2 commits November 27, 2023 22:19

Correct null handling when having a nullable struct propertywith a cu…

2507a7e

…stom comparer. #2480

Release notes added

85d0167

MartinDemberger marked this pull request as ready for review November 27, 2023 21:40

IT-VBFK reviewed Nov 27, 2023

View reviewed changes

docs/_pages/releases.md Outdated Show resolved Hide resolved

typo corrected

449d951

dennisdoomen reviewed Nov 30, 2023

View reviewed changes

Src/FluentAssertions/Equivalency/Steps/EqualityComparerEquivalencyStep.cs Outdated Show resolved Hide resolved

MartinDembergerR9 added 2 commits November 30, 2023 19:49

Removed the check for only value types and added the null check for t…

a730783

…he expectation. Also added more tests for all cases.

typo corrected

621c6cd

IT-VBFK reviewed Nov 30, 2023

View reviewed changes

Tests/FluentAssertions.Equivalency.Specs/ExtensibilitySpecs.cs Outdated Show resolved Hide resolved

Tests/FluentAssertions.Equivalency.Specs/ExtensibilitySpecs.cs Outdated Show resolved Hide resolved

Merge branch 'fluentassertions:develop' into 2480_Equivalent_null

b5a85d4

MartinDembergerR9 added 2 commits December 2, 2023 16:02

Warnings solved

b146688

Added a comment for the changed code

afa6bb0

dennisdoomen reviewed Dec 5, 2023

View reviewed changes

Tests/FluentAssertions.Equivalency.Specs/ExtensibilitySpecs.cs Show resolved Hide resolved

Src/FluentAssertions/Equivalency/Steps/EqualityComparerEquivalencyStep.cs Outdated Show resolved Hide resolved

Comment cleaned

4a320a0

dennisdoomen changed the title ~~Correct null handling when having a nullable struct propertywith a custom comparer~~ Correct null handling when having a nullable struct property with a custom comparer Dec 9, 2023

dennisdoomen approved these changes Dec 9, 2023

View reviewed changes

dennisdoomen requested a review from jnyrup December 11, 2023 17:44

jnyrup linked an issue Dec 12, 2023 that may be closed by this pull request

BeEquivalent failed with nullably struct property and EqualityComparer #2480

Closed

jnyrup reviewed Dec 12, 2023

View reviewed changes

docs/_pages/releases.md Outdated Show resolved Hide resolved

Update docs/_pages/releases.md

e3e3305

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

ITaluone reviewed Dec 15, 2023

View reviewed changes

Src/FluentAssertions/Equivalency/Steps/EqualityComparerEquivalencyStep.cs Outdated Show resolved Hide resolved

MartinDemberger and others added 2 commits December 15, 2023 14:12

Typo corrected

23b26a2

Co-authored-by: ITaluone <44049228+ITaluone@users.noreply.github.com>

Merge from main branch

12d1309

MartinDembergerR9 and others added 3 commits December 20, 2023 22:22

Corrected Qodana issues

e0cae8b

Merge branch 'fluentassertions:develop' into 2480_Equivalent_null

a17c561

cleanups

39effbc

jnyrup approved these changes Dec 29, 2023

View reviewed changes

jnyrup changed the title ~~Correct null handling when having a nullable struct property with a custom comparer~~ Correct null handling when using a custom comparer Dec 29, 2023

jnyrup merged commit 666c348 into fluentassertions:develop Dec 29, 2023
3 of 5 checks passed

jnyrup mentioned this pull request Dec 29, 2023

Cleanups #2529

Merged

7 tasks

jnyrup added the bug label Jan 6, 2024

arocheleau mentioned this pull request Mar 22, 2024

Null reference exception when using custom comparer in equivalency options #2595

Closed

jnyrup mentioned this pull request Apr 7, 2024

FluentAssertions: using a NullorEqual string EqualityComparer still returns a type difference error #2621

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correct null handling when using a custom comparer #2489

Correct null handling when using a custom comparer #2489

MartinDemberger commented Nov 27, 2023

github-actions bot commented Nov 27, 2023 •

edited

Loading

MartinDemberger commented Dec 1, 2023

IT-VBFK commented Dec 1, 2023

github-actions bot commented Dec 1, 2023 •

edited

Loading

coveralls commented Dec 9, 2023 •

edited

Loading

github-actions bot commented Dec 15, 2023 •

edited

Loading

ITaluone commented Dec 18, 2023

Correct null handling when using a custom comparer #2489

Correct null handling when using a custom comparer #2489

Conversation

MartinDemberger commented Nov 27, 2023

IMPORTANT

github-actions bot commented Nov 27, 2023 • edited Loading

Qodana for .NET

MartinDemberger commented Dec 1, 2023

IT-VBFK commented Dec 1, 2023

github-actions bot commented Dec 1, 2023 • edited Loading

Qodana for .NET

coveralls commented Dec 9, 2023 • edited Loading

Pull Request Test Coverage Report for Build 7357619396

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

github-actions bot commented Dec 15, 2023 • edited Loading

Qodana for .NET

ITaluone commented Dec 18, 2023

github-actions bot commented Nov 27, 2023 •

edited

Loading

github-actions bot commented Dec 1, 2023 •

edited

Loading

coveralls commented Dec 9, 2023 •

edited

Loading

github-actions bot commented Dec 15, 2023 •

edited

Loading