Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update includes for docs/pt/docs/python-types.md #12671

Merged
merged 3 commits into from
Nov 9, 2024

Conversation

ceb10n
Copy link
Contributor

@ceb10n ceb10n commented Oct 28, 2024

No description provided.

@github-actions github-actions bot added the lang-all Translations label Oct 28, 2024
Copy link
Contributor

@estebanx64 estebanx64 added lang-pt Portuguese translations awaiting-review labels Oct 29, 2024
@nazarepiedady
Copy link
Contributor

@cassiobotaro, what do you think about this pull request?

@ceb10n
Copy link
Contributor Author

ceb10n commented Oct 29, 2024

I've seen that Alejandra commented on this other PR, and my PR has the same problems 👀 .

I'm going to fix it tomorrow 😄

@alejsdev alejsdev added docs Documentation about how to use FastAPI and removed lang-all Translations lang-pt Portuguese translations awaiting-review labels Oct 29, 2024
@github-actions github-actions bot added the lang-all Translations label Oct 31, 2024
@ceb10n
Copy link
Contributor Author

ceb10n commented Oct 31, 2024

Done.

If you can review @alejsdev. I confess I got a little confused with this one 😄

I used the english version as reference

Copy link
Contributor

@ceb10n
Copy link
Contributor Author

ceb10n commented Oct 31, 2024

And I believe that the github-actions bot just broke the labels:

@github-actions github-actions bot added the lang-all label 4 minutes ago

Error:  Label check failed: required 1 of 'breaking', 'security', 'feature', 'bug', 'refactor', 'upgrade', 'docs', 'lang-all', 'internal', but found 2: 'docs', 'lang-all'

Apparently the check-labels action doesn't accept lang-all and docs at the same time 😢

@alejsdev alejsdev removed the lang-all Translations label Nov 8, 2024
@alejsdev alejsdev merged commit 51fe0e4 into fastapi:master Nov 9, 2024
51 of 52 checks passed
@alejsdev
Copy link
Member

alejsdev commented Nov 9, 2024

Hi @ceb10n, thanks for your help 💯
I reviewed it and it looks good to me 😄 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants