Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for docs/ko/docs/fastapi-cli.md #12515

Merged
merged 8 commits into from
Oct 28, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/fastapi-cli.md #12515

merged 8 commits into from
Oct 28, 2024

Conversation

dhdld
Copy link
Contributor

@dhdld dhdld commented Oct 23, 2024

No description provided.

@github-actions github-actions bot added the lang-all Translations label Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 25fcfbe at: https://49b8b2a6.fastapitiangolo.pages.dev

Modified Pages

@alejsdev alejsdev changed the title 🌐 Add Korean translation for /docs/ko/docs/fastapi-cli.md 🌐 Add Korean translation for docs/ko/docs/fastapi-cli.md Oct 23, 2024
@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Oct 23, 2024
hard-coders
hard-coders approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

BORA040126
BORA040126 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@BORA040126 BORA040126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sodaMelon
sodaMelon reviewed Oct 24, 2024
View reviewed changes
Copy link

@sodaMelon sodaMelon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi. thank Thanks for the PR.
i left comments because some sentences are unclear.
명확하지 않은 문장 위주로 제안 드렸습니다. 확인부탁드립니다!

dhdld and others added 3 commits October 24, 2024 23:41
@dhdld @sodaMelon
Update docs/ko/docs/fastapi-cli.md
5d7f784 
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@dhdld @sodaMelon
Update docs/ko/docs/fastapi-cli.md
dc11c07 
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@dhdld @sodaMelon
Update docs/ko/docs/fastapi-cli.md
88d9379 
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 88d9379 at: https://5a263965.fastapitiangolo.pages.dev

Modified Pages

@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 0d97716 at: https://d0ab85a5.fastapitiangolo.pages.dev

Modified Pages

@dhdld
Copy link
Contributor Author

dhdld commented Oct 24, 2024

comments 확인하여 명확하지 않은 문장 수정했습니다.
Reviewed the comments and revised unclear sentences.

@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 6812847 at: https://744ae372.fastapitiangolo.pages.dev

Modified Pages

@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit d68d9c4 at: https://8131e1ff.fastapitiangolo.pages.dev

Modified Pages

@sodaMelon
Copy link

sodaMelon commented Oct 27, 2024 •
edited
Loading

comments 확인하여 명확하지 않은 문장 수정했습니다. Reviewed the comments and revised unclear sentences.

LGTM 💖
(수신 대기<-에 관련된 코멘트는 지웠습니다. 저도 주말동안 고민해봤는데 생각이 나질 않네요.... 수정 고생하셨습니다!)

@alejsdev alejsdev enabled auto-merge (squash) October 28, 2024 11:26
@alejsdev
Copy link
Member

Thanks for your contribution! @dhdld 🎉
And thanks for the help @sodaMelon @hard-coders 🔍

@alejsdev alejsdev merged commit 5c33269 into fastapi:master Oct 28, 2024
56 checks passed
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
@dhdld @s-rigaud
🌐 Add Korean translation for docs/ko/docs/fastapi-cli.md (fastapi#1…
9f5c9ac 
…2515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BORA040126 BORA040126 BORA040126 approved these changes

@sodaMelon sodaMelon sodaMelon approved these changes

@hard-coders hard-coders hard-coders approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhdld @sodaMelon @alejsdev @hard-coders @BORA040126