Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update docs/en/docs/tutorial/dependencies/dependencies-with-yield.md #12045

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

xuvjso
Copy link
Contributor

@xuvjso xuvjso commented Aug 19, 2024

After FastAPI 0.106.0, the code after yield now runs after the response is created but before it is sent to the client.

@github-actions github-actions bot added the docs Documentation about how to use FastAPI label Aug 19, 2024
@alejsdev alejsdev changed the title Update docs/en/docs/tutorial/dependencies/dependencies-with-yield.md Update docs/en/docs/tutorial/dependencies/dependencies-with-yield.md Aug 19, 2024
@alejsdev alejsdev changed the title Update docs/en/docs/tutorial/dependencies/dependencies-with-yield.md 📝 Update docs/en/docs/tutorial/dependencies/dependencies-with-yield.md Aug 19, 2024
Copy link
Contributor

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution! 🙏

I'm not sure I fully understand the suggestion here, and what "but before sending it" actually means. You mention that this has changed after FastAPI 0.106.0, can you share a link to the relevant commit/PR/change log?

[UPDATE]: Ah, found it, this is probably related to #10831?

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I think this looks good, thanks again! 🙏

Copy link
Contributor

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good catch @xuvjso. thanks! 🚀 🍰

@tiangolo tiangolo merged commit 9aaeb8b into fastapi:master Nov 10, 2024
49 checks passed
@xuvjso xuvjso deleted the dependencies-with-yield-en-docs-fix branch November 14, 2024 17:34
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
…md` (fastapi#12045)

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants