-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Update docs/en/docs/tutorial/dependencies/dependencies-with-yield.md
#12045
📝 Update docs/en/docs/tutorial/dependencies/dependencies-with-yield.md
#12045
Conversation
docs/en/docs/tutorial/dependencies/dependencies-with-yield.md
docs/en/docs/tutorial/dependencies/dependencies-with-yield.md
docs/en/docs/tutorial/dependencies/dependencies-with-yield.md
📝 Docs preview for commit 81bc206 at: https://f04d7eae.fastapitiangolo.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your contribution! 🙏
I'm not sure I fully understand the suggestion here, and what "but before sending it" actually means. You mention that this has changed after FastAPI 0.106.0, can you share a link to the relevant commit/PR/change log?
[UPDATE]: Ah, found it, this is probably related to #10831?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I think this looks good, thanks again! 🙏
📝 Docs preview for commit f439898 at: https://e899cbec.fastapitiangolo.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good catch @xuvjso. thanks! 🚀 🍰
…md` (fastapi#12045) Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
After FastAPI 0.106.0, the code after yield now runs after the response is created but before it is sent to the client.