[Fizz] Allow aborting during render #30488
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
React Core Team
gnoff
force-pushed
the
fizz-allow-abort-during-render
branch
from
bd5d88a to
13eeb69
Compare
| __DEV__ && enableOwnerStacks ? task.debugTask : null, | ||
| ); | ||
|
|
||
| if (x === AbortSigil) { |
There was a problem hiding this comment.
If we abort sync in a resume, this can happen too right? Therefore you need to handle the same thing in retryReplayTask.
| @@ -1580,6 +1601,13 @@ function finishClassComponent( | |||
| nextChildren = instance.render(); | |||
| } | |||
|
|
|||
| if (request.status === ABORTING) { | |||
There was a problem hiding this comment.
There are so many places we need to check this for Fizz so I think maybe we should just put it after everywhere we call retryNode:
https://github.com/facebook/react/blob/main/packages/react-server/src/ReactFizzServer.js#L2516
Or maybe at least before every return inside retryNode that might have user space code in it.
There was a problem hiding this comment.
discussed offline. This is tricky b/c we can end up aborting too high. For now we'll just support the obvious places where user code can run like function and class components and lazy initializers. We can revisit and expand support to iterables and other places if we find a strong motivation in the future. The use case for aborting in these other places is a bit esoteric
gnoff
force-pushed
the
fizz-allow-abort-during-render
branch
from
13eeb69 to
7598d32
Compare
gnoff
force-pushed
the
fizz-allow-abort-during-render
branch
from
7598d32 to
d9ed043
Compare
Currently if you abort a Fizz render during rendering the render will not complete correctly because there are inconsistencies with task counting. This change updates the abort implementation to allow you to abort from within a render itself. We already landed a similar change for Flight in facebook#29764
gnoff
force-pushed
the
fizz-allow-abort-during-render
branch
from
d9ed043 to
fb0bd66
Compare
Currently if you abort a Fizz render during rendering the render will not complete correctly because there are inconsistencies with task counting. This change updates the abort implementation to allow you to abort from within a render itself. We already landed a similar change for Flight in #29764 DiffTrain build for [a451de0](a451de0)
Currently if you abort a Fizz render during rendering the render will not complete correctly because there are inconsistencies with task counting. This change updates the abort implementation to allow you to abort from within a render itself. We already landed a similar change for Flight in #29764