[lexical-playground] Fix table hover actions button position #7011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivailop7
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
etrepum
approved these changes
Jan 1, 2025
There was a problem hiding this comment.
Not a complete fix because there's no scroll event handling (looking forward to #6923 so all of these things can be fixed). A visible button will remain in a fixed position while the table scrolls behind it. Also a bit of a hack because it doesn't use the theme, but it is playground-only code so that's a bit par for the course.
| @@ -115,6 +115,19 @@ function TableHoverActionsContainer({ | |||
| height: tableElemHeight, | |||
| } = (tableDOMElement as HTMLTableElement).getBoundingClientRect(); | |||
|
|
|||
| // Adjust for using the scrollable table container | |||
| const parentElement = (tableDOMElement as HTMLTableElement) | |||
There was a problem hiding this comment.
A more robust check here would be to compare tableDOMElement to parentElement = editor.getElementByKey(table.getKey()) - if they are not identical, then the latter is the outermost wrapping node. This is already computed above just not saved to its own variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing the getDOMSlot usage, the render coordinates for the table hover actions had to be adjusted.
Before:
Screen.Recording.2025-01-01.at.14.17.56.mov
After:
Screen.Recording.2025-01-01.at.14.17.30.mov