Add pre commit hooks to readme #462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @0x26res! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hick209
approved these changes
Apr 28, 2024
github-merge-queue bot
referenced
this pull request
in slackhq/circuit
Jun 7, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.facebook:ktfmt](https://togithub.com/facebook/ktfmt) | dependencies | minor | `0.49` -> `0.50` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>facebook/ktfmt (com.facebook:ktfmt)</summary> ### [`v0.50`](https://togithub.com/facebook/ktfmt/releases/tag/v0.50): 0.50 #### Changelog - Add pre commit hooks to readme ([https://github.com/facebook/ktfmt/pull/462](https://togithub.com/facebook/ktfmt/pull/462)) – [@​0x26res](https://togithub.com/0x26res) - Add homebrew installation note to readme ([https://github.com/facebook/ktfmt/pull/468](https://togithub.com/facebook/ktfmt/pull/468)) – [@​chenrui333](https://togithub.com/chenrui333) - Refactor CLI argument parsing ([https://github.com/facebook/ktfmt/pull/467](https://togithub.com/facebook/ktfmt/pull/467)) – [@​grodin](https://togithub.com/grodin) - Fix issue with context receive in lambdas ([https://github.com/facebook/ktfmt/issues/471](https://togithub.com/facebook/ktfmt/issues/471)) – [@​hick209](https://togithub.com/hick209) - Don't reorder [@​sample](https://togithub.com/sample) tag ([https://github.com/facebook/ktfmt/issues/406](https://togithub.com/facebook/ktfmt/issues/406)) – [@​davidtorosyan](https://togithub.com/davidtorosyan) **Full Changelog**: facebook/ktfmt@v0.49...v0.50 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTYuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM5Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
slack-oss-bot
referenced
this pull request
in slackhq/foundry
Jun 10, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.facebook:ktfmt](https://togithub.com/facebookincubator/ktfmt) | dependencies | minor | `0.49` -> `0.50` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>facebookincubator/ktfmt (com.facebook:ktfmt)</summary> ### [`v0.50`](https://togithub.com/facebook/ktfmt/releases/tag/v0.50): 0.50 #### Changelog - Add pre commit hooks to readme ([https://github.com/facebook/ktfmt/pull/462](https://togithub.com/facebook/ktfmt/pull/462)) – [@​0x26res](https://togithub.com/0x26res) - Add homebrew installation note to readme ([https://github.com/facebook/ktfmt/pull/468](https://togithub.com/facebook/ktfmt/pull/468)) – [@​chenrui333](https://togithub.com/chenrui333) - Refactor CLI argument parsing ([https://github.com/facebook/ktfmt/pull/467](https://togithub.com/facebook/ktfmt/pull/467)) – [@​grodin](https://togithub.com/grodin) - Fix issue with context receive in lambdas ([https://github.com/facebook/ktfmt/issues/471](https://togithub.com/facebook/ktfmt/issues/471)) – [@​hick209](https://togithub.com/hick209) - Don't reorder [@​sample](https://togithub.com/sample) tag ([https://github.com/facebook/ktfmt/issues/406](https://togithub.com/facebook/ktfmt/issues/406)) – [@​davidtorosyan](https://togithub.com/davidtorosyan) **Full Changelog**: facebook/ktfmt@v0.49...v0.50 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTYuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM5Ni4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
ZacSweers
referenced
this pull request
in ZacSweers/CatchUp
Jun 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.facebook:ktfmt](https://togithub.com/facebook/ktfmt) | `0.49` -> `0.51` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>facebook/ktfmt (com.facebook:ktfmt)</summary> ### [`v0.51`](https://togithub.com/facebook/ktfmt/blob/HEAD/CHANGELOG.md#051) ##### Added - Created CHANGELOG.md - Added --help option to CLI ([https://github.com/facebook/ktfmt/pull/477](https://togithub.com/facebook/ktfmt/pull/477)) ##### Changed - Preserves blank spaces between when clauses ([https://github.com/facebook/ktfmt/issues/342](https://togithub.com/facebook/ktfmt/issues/342)) - Named the default style as `Formatter.META_FORMAT` / `--meta-style` - `FormattingOptions` constructor parameters order was changed ##### Fixed - Compilation issues with online formatter (facebook/ktfmt@8605080) - Removing valid semicolons ([https://github.com/facebook/ktfmt/issues/459](https://togithub.com/facebook/ktfmt/issues/459)) - Incorrect detection of unused `assign` import ([https://github.com/facebook/ktfmt/issues/411](https://togithub.com/facebook/ktfmt/issues/411)) ##### Removed - **Deleted `Formatter.DROPBOX_FORMAT` / `--dropbox-style` (BREAKING CHANGE)** - Deleted `FormattingOptions.Style` enum ### [`v0.50`](https://togithub.com/facebook/ktfmt/releases/tag/v0.50): 0.50 #### Changelog - Add pre commit hooks to readme ([https://github.com/facebook/ktfmt/pull/462](https://togithub.com/facebook/ktfmt/pull/462)) – [@​0x26res](https://togithub.com/0x26res) - Add homebrew installation note to readme ([https://github.com/facebook/ktfmt/pull/468](https://togithub.com/facebook/ktfmt/pull/468)) – [@​chenrui333](https://togithub.com/chenrui333) - Refactor CLI argument parsing ([https://github.com/facebook/ktfmt/pull/467](https://togithub.com/facebook/ktfmt/pull/467)) – [@​grodin](https://togithub.com/grodin) - Fix issue with context receive in lambdas ([https://github.com/facebook/ktfmt/issues/471](https://togithub.com/facebook/ktfmt/issues/471)) – [@​hick209](https://togithub.com/hick209) - Don't reorder [@​sample](https://togithub.com/sample) tag ([https://github.com/facebook/ktfmt/issues/406](https://togithub.com/facebook/ktfmt/issues/406)) – [@​davidtorosyan](https://togithub.com/davidtorosyan) **Full Changelog**: facebook/ktfmt@v0.49...v0.50 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ZacSweers/CatchUp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently added support for ktfmt to pre-commit hooks.
macisamuele/language-formatters-pre-commit-hooks#196
I thought it'd be worth mentioning in the README.