Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing backticks to flags.js #19226

Merged

Conversation

lumirlumir
Copy link
Contributor

@lumirlumir lumirlumir commented Dec 6, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

What changes did you make? (Give an overview)

Hello, I've added missing backticks to flags.js.

While eslint.config.js is consistently wrapped in backticks throughout the documentation, it was missing in flags.js.

image

  • E.g., eslint.config.js is wrapped in backticks throughout the documentation like the screenshot below.

    image

Is there anything you'd like reviewers to focus on?

@lumirlumir lumirlumir requested a review from a team as a code owner December 6, 2024 16:13
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Dec 6, 2024
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 40d320a
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/675322e43fc285000984a6ca

Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Dec 6, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit 4c4f53b into eslint:main Dec 9, 2024
25 of 26 checks passed
@lumirlumir lumirlumir deleted the chore-add-missing-backticks-to-flags-js branch December 23, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants