Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing backticks to prefer-destructuring #19223

Conversation

lumirlumir
Copy link
Contributor

@lumirlumir lumirlumir commented Dec 6, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Hello,

I've added missing backticks to prefer-destructuring.md.

I believe that true should be wrapped in backticks like the screenshot below.

image

Is there anything you'd like reviewers to focus on?

@lumirlumir lumirlumir requested a review from a team as a code owner December 6, 2024 10:48
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Dec 6, 2024
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 09b6281
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6752d689fb911b000837f078
😎 Deploy Preview https://deploy-preview-19223--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 4a6882c
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6752d69a2b8f860008d80a52
😎 Deploy Preview https://deploy-preview-19223--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 1eb424d into eslint:main Dec 6, 2024
27 checks passed
@lumirlumir lumirlumir deleted the docs-add-missing-backticks-to-prefer-destructuring branch December 6, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants