docs: add no-useless-computed-key examples with object patterns
#19109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
added
rule
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This seems to be a bug introduced with #7934. Apparently it wasn't considered that the rule also applies to object patterns at the time of that change. I think it should be fixed as per our policy. @nzakas what do you think? |
|
I agree, let's fix it. I'm assuming that would be a separate PR? |
Yes, it seems better to fix that in a separate PR so that this one just documents the existing behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Closes #12048
What changes did you make? (Give an overview)
This PR documents that
no-useless-computed-keyalso applies to object patterns. I added several tests to confirm the behavior.Is there anything you'd like reviewers to focus on?
['__proto__']in object patterns is a false negative. Shall we fix it or leave the behavior as is?