fix: switch grapheme-splitter to graphemer
#17160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
|
Thanks for the PR @fisker. I can see that the issue in your snippet is affecting the behavior of the For example: /* eslint key-spacing: ["error", { align: "value" }] */
const foo = {
"👍👍👍": 1, // false positive
"👩🦰👩👩👦👦🏳️🌈": 2,
};
const bar = {
"👍👍👍👍": 1,
"👩🦰👩👩👦👦🏳️🌈": 2, // false negative
}; |
fasttime
added
repro:yes
mdjermanovic
reviewed
May 8, 2023
lib/shared/string-utils.js
Outdated
Comment on lines
45
to
51
| if (typeof Intl !== "undefined" && typeof Intl.Segmenter !== "undefined") { | ||
| iterateGraphemes = Intl.Segmenter.prototype.segment.bind(new Intl.Segmenter()); | ||
| } else { | ||
| const Graphemer = require("graphemer").default; | ||
|
|
||
| iterateGraphemes = Graphemer.prototype.iterateGraphemes.bind(new Graphemer()); | ||
| } |
There was a problem hiding this comment.
Do these two methods always give the same result? If we can't guarantee that, it would be better to switch to just graphemer now and then just Intl.Segmenter in the next major version (when we drop Node < 16), because we wouldn't want linting to produce different results in different environments.
fisker
changed the title
getGraphemeCountgrapheme-splitter to graphemer
mdjermanovic
approved these changes
May 8, 2023
There was a problem hiding this comment.
LGTM, thanks! Leaving open for others to review, and waiting for #17116 to be closed before merging.
Closed
4 tasks
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Switch
grapheme-splittertographemer.Use
Intl.Segmenterwhen available.What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?