Update: do not recommend require-atomic-updates (refs #11899) #12599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kaicataldo
force-pushed
the
fix-require-atomic-updates-recommended
branch
from
99e4dd8 to
3e4e439
Compare
kaicataldo
changed the title
kaicataldo
added
bug
platinumazure
approved these changes
Nov 25, 2019
ljharb
approved these changes
Nov 25, 2019
saveman71
approved these changes
Nov 25, 2019
ilyavolodin
approved these changes
Nov 27, 2019
jackodsteel
added a commit
to jackodsteel/cacophony-api
that referenced
this pull request
Dec 4, 2019
Also turned off a random check that got introduced that's due to be disabled as it's too noisy (although maybe we consider fixing these if that's possible?) eslint/eslint#12599 Also bumped the local eslint version as it's behind what gets installed by travis.
This was referenced Jan 12, 2020
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #11899 (comment)
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
What changes did you make? (Give an overview)
The TSC made a determination to remove
require-atomic-updatesfromeslint:recommended, but it looks like we didn't end up making that change.Is there anything you'd like reviewers to focus on?
Nothing in particular.