Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setTopBrowserView focus issue with reordering #42733

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jul 1, 2024

Backport of #42653

See that PR for details.

Notes: Fixed a focus issue when calling BrowserWindow.setTopBrowserView

trop bot and others added 3 commits July 1, 2024 09:36
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
@trop trop bot requested review from alicelovescake and a team July 1, 2024 09:36
@trop trop bot added 32-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 1, 2024
@codebytere
Copy link
Member

Unrelated test failure:

iframe using HTML fullscreen API while window is OS-fullscreened can fullscreen from out-of-process iframes

@codebytere codebytere merged commit de6e6b6 into 32-x-y Jul 3, 2024
52 of 54 checks passed
@codebytere codebytere deleted the trop/32-x-y-bp-fix-settopbrowserview-focus-issue-with-reordering-1719826571810 branch July 3, 2024 10:43
Copy link

release-clerk bot commented Jul 3, 2024

Release Notes Persisted

Fixed a focus issue when calling BrowserWindow.setTopBrowserView

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
32-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants