Fix file updater removing variants from docker tags #5560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavera
approved these changes
Aug 19, 2022
It was only using the last new requirement while I believe it should be using the corresponding updated requirement for each old requirement.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/docker-update-removing-slim
branch
from
e873a13 to
d9b68b5
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/docker-update-removing-slim
branch
Merged
This was referenced Aug 23, 2022
Closed
|
@deivid-rodriguez we might need to re-evaluate this one... see: #3261 (comment) |
This was referenced Aug 29, 2022
Closed
This was referenced Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only using the last new requirement while I believe it should be using the corresponding updated requirement for each old requirement.
Fixes #5538.