Make composition revision numbers mutable #5939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were made immutable by mistake. Signed-off-by: Nic Cope <nicc@rk0n.org>
|
@jbw976 Maybe we should wait a week or so before cutting a patch? Just in case anything else shows up. |
|
Sounds good! I went ahead and opened crossplane/release#20 to track a v1.17.1 patch release and I set a reminder to follow-up then 😉 |
phisco
approved these changes
Sep 6, 2024
|
Lots of CI failures on the Claim SSA and realtime compositions tests on this PR, but I can't imagine they're related in any way to the change. 🤔 |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #5928
Revision numbers were made immutable by mistake. See #5928 (comment) for context.
I have:
earthly +reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.