Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crossplane xpkg init doesn't close file #5720

Merged
merged 4 commits into from
May 22, 2024

Conversation

cychiang
Copy link
Contributor

@cychiang cychiang commented May 21, 2024

Description of your changes

Based on the previous #5632 with the fix for linting.

I believe it's safe to not handle the error. The whole function is doing read only, and not doing any write operation.

Fixes #5717

I have:

Need help with this checklist? See the cheat sheet.

@cychiang cychiang requested review from phisco and a team as code owners May 21, 2024 10:54
@cychiang cychiang requested a review from bobh66 May 21, 2024 10:54
Signed-off-by: Chuan-Yen Chiang <cychiang0823@gmail.com>
Signed-off-by: Chuan-Yen Chiang <chuanyen.chiang@volvocars.com>
@cychiang cychiang force-pushed the fix-xpkg-doesnt-close-file branch from e75cc03 to d88600f Compare May 21, 2024 10:55
…ore.

Signed-off-by: Chuan-Yen Chiang <chuanyen.chiang@volvocars.com>
@cychiang cychiang force-pushed the fix-xpkg-doesnt-close-file branch from 71021f6 to 9644d74 Compare May 21, 2024 11:02
cmd/crank/beta/xpkg/init.go Outdated Show resolved Hide resolved
cychiang added 2 commits May 21, 2024 22:44
Signed-off-by: Chuan-Yen Chiang <chuanyen.chiang@volvocars.com>
Signed-off-by: Chuan-Yen Chiang <chuanyen.chiang@volvocars.com>
@cychiang cychiang requested review from bobh66 and negz May 22, 2024 02:20
@negz
Copy link
Member

negz commented May 22, 2024

Thank you!

@phisco phisco merged commit fe4b4fc into crossplane:master May 22, 2024
16 of 19 checks passed
@cychiang cychiang deleted the fix-xpkg-doesnt-close-file branch December 22, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crossplane xpkg init doesn't close file
4 participants