Use a stripped out crossplane/build submodule fork
#5693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
negz
force-pushed
the
its-happening-dot-gif
branch
3 times, most recently
from
110e347 to
b86b3d3
Compare
negz
force-pushed
the
its-happening-dot-gif
branch
2 times, most recently
from
ab4ab77 to
93a8a85
Compare
Signed-off-by: Nic Cope <nicc@rk0n.org>
negz
force-pushed
the
its-happening-dot-gif
branch
from
93a8a85 to
ac5edfd
Compare
jbw976
approved these changes
May 16, 2024
I assume this was true when the PR was opened, but looks like it's been cut over to |
@jbw976 Whoops, yes I forgot to remove that from the description. Will do now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1583
This PR switches c/c over to use https://github.com/crossplane/build, not https://github.com/upbound/build.
I have:
make reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.