Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scope() function soft-deprecated #954

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 18, 2023

Make crossbeam's scope() function soft-deprecated in favor of the more efficient std::thread::scope that stabilized on Rust 1.63.

Closes #816
Closes #844

Make crossbeam's `scope()` function soft-deprecated in favor of the more
efficient `std::thread::scope` that stabilized on Rust 1.63.
@taiki-e
Copy link
Member Author

taiki-e commented Jan 18, 2023

I don't see much motivation to rework crossbeam's scope() function like #844, given that the std::thread::scope is already stable.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 18, 2023

@bors bors bot merged commit f45c4c1 into master Jan 18, 2023
@bors bors bot deleted the taiki-e/scoped-thread3 branch January 18, 2023 15:37
bors bot added a commit that referenced this pull request Feb 28, 2023
964: v0.8: Prepare for the next release r=taiki-e a=taiki-e

Changes:
- crossbeam-channel 0.5.6 -> 0.5.7
  - Improve handling of very large timeout. (#953)
- crossbeam-deque 0.8.2 -> 0.8.3
  - Add `Stealer::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
  - Add `Injector::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
- crossbeam-epoch 0.9.13 -> 0.9.14
  - Update `memoffset` to 0.8. (#955)
- crossbeam-utils 0.8.14 -> 0.8.15
  - Add `#[clippy::has_significant_drop]` to `ShardedLock{Read,Write}Guard`. (#958)
  - Improve handling of very large timeout. (#953)
  - Soft-deprecate `thread::scope()` in favor of the more efficient `std::thread::scope` that stabilized on Rust 1.63. (#954)

Backports:
- #903
- #936
- #953
- #954
- #955
- #958

Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Co-authored-by: Alexis (Poliorcetics) Bourget <alexis.bourget@gmail.com>
Co-authored-by: Caio <c410.f3r@gmail.com>
bors bot added a commit that referenced this pull request Feb 28, 2023
964: v0.8: Prepare for the next release r=taiki-e a=taiki-e

Changes:
- crossbeam-channel 0.5.6 -> 0.5.7
  - Improve handling of very large timeout. (#953)
- crossbeam-deque 0.8.2 -> 0.8.3
  - Add `Stealer::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
  - Add `Injector::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
- crossbeam-epoch 0.9.13 -> 0.9.14
  - Update `memoffset` to 0.8. (#955)
- crossbeam-utils 0.8.14 -> 0.8.15
  - Add `#[clippy::has_significant_drop]` to `ShardedLock{Read,Write}Guard`. (#958)
  - Improve handling of very large timeout. (#953)
  - Soft-deprecate `thread::scope()` in favor of the more efficient `std::thread::scope` that stabilized on Rust 1.63. (#954)

Backports:
- #903
- #936
- #953
- #954
- #955
- #958

Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Co-authored-by: Alexis (Poliorcetics) Bourget <alexis.bourget@gmail.com>
Co-authored-by: Caio <c410.f3r@gmail.com>
bors bot added a commit that referenced this pull request Feb 28, 2023
964: v0.8: Prepare for the next release r=taiki-e a=taiki-e

Changes:
- crossbeam-channel 0.5.6 -> 0.5.7
  - Improve handling of very large timeout. (#953)
- crossbeam-deque 0.8.2 -> 0.8.3
  - Add `Stealer::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
  - Add `Injector::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
- crossbeam-epoch 0.9.13 -> 0.9.14
  - Update `memoffset` to 0.8. (#955)
- crossbeam-utils 0.8.14 -> 0.8.15
  - Add `#[clippy::has_significant_drop]` to `ShardedLock{Read,Write}Guard`. (#958)
  - Improve handling of very large timeout. (#953)
  - Soft-deprecate `thread::scope()` in favor of the more efficient `std::thread::scope` that stabilized on Rust 1.63. (#954)

Backports:
- #903
- #936
- #953
- #954
- #955
- #958

Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Co-authored-by: Alexis (Poliorcetics) Bourget <alexis.bourget@gmail.com>
Co-authored-by: Caio <c410.f3r@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Memory leak in crossbeam_utils::thread::scope(): Unbounded memory usage with long-lived scopes
1 participant