Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deque: add new method to limit batch steal size #903

Merged
merged 1 commit into from
Sep 11, 2022
Merged

deque: add new method to limit batch steal size #903

merged 1 commit into from
Sep 11, 2022

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Aug 30, 2022

No description provided.

@glorv glorv force-pushed the steal-with-limit branch 4 times, most recently from ffd87ca to c0791dd Compare September 5, 2022 12:22
taiki-e
taiki-e reviewed Sep 7, 2022
View reviewed changes
crossbeam-deque/src/deque.rs Outdated Show resolved Hide resolved
crossbeam-deque/src/deque.rs Outdated Show resolved Hide resolved
taiki-e
taiki-e reviewed Sep 10, 2022
View reviewed changes
crossbeam-deque/src/deque.rs Outdated Show resolved Hide resolved
crossbeam-deque/src/deque.rs Outdated Show resolved Hide resolved
crossbeam-deque/src/deque.rs Outdated Show resolved Hide resolved
crossbeam-deque/src/deque.rs Outdated Show resolved Hide resolved
crossbeam-deque/src/deque.rs Show resolved Hide resolved
crossbeam-deque/src/deque.rs Outdated Show resolved Hide resolved
crossbeam-deque/src/deque.rs Outdated Show resolved Hide resolved
taiki-e
taiki-e approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @glorv!

bors r+

bors bot added a commit that referenced this pull request Sep 11, 2022
@bors @glorv
Merge #903
1a2c156 
903: deque: add new method to limit batch steal size r=taiki-e a=glorv



Co-authored-by: glorv <glorvs@163.com>
@bors
Copy link
Contributor

bors bot commented Sep 11, 2022

Timed out.

@taiki-e
Copy link
Member

taiki-e commented Sep 11, 2022

bors retry

@bors
Copy link
Contributor

bors bot commented Sep 11, 2022

Build succeeded:

@bors bors bot merged commit 41ed3d9 into crossbeam-rs:master Sep 11, 2022
@BusyJay
Copy link
Contributor

BusyJay commented Feb 28, 2023

@taiki-e Hi, can we get a release for this patch?

@taiki-e
Copy link
Member

taiki-e commented Feb 28, 2023

Oh, sorry, I missed this had not been released. I will release it tonight.

@taiki-e taiki-e mentioned this pull request Feb 28, 2023
Merged
bors bot added a commit that referenced this pull request Feb 28, 2023
@bors @glorv
@taiki-e @poliorcetics @c410-f3r
Merge #964
4778b46 
964: v0.8: Prepare for the next release r=taiki-e a=taiki-e

Changes:
- crossbeam-channel 0.5.6 -> 0.5.7
  - Improve handling of very large timeout. (#953)
- crossbeam-deque 0.8.2 -> 0.8.3
  - Add `Stealer::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
  - Add `Injector::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
- crossbeam-epoch 0.9.13 -> 0.9.14
  - Update `memoffset` to 0.8. (#955)
- crossbeam-utils 0.8.14 -> 0.8.15
  - Add `#[clippy::has_significant_drop]` to `ShardedLock{Read,Write}Guard`. (#958)
  - Improve handling of very large timeout. (#953)
  - Soft-deprecate `thread::scope()` in favor of the more efficient `std::thread::scope` that stabilized on Rust 1.63. (#954)

Backports:
- #903
- #936
- #953
- #954
- #955
- #958

Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Co-authored-by: Alexis (Poliorcetics) Bourget <alexis.bourget@gmail.com>
Co-authored-by: Caio <c410.f3r@gmail.com>
bors bot added a commit that referenced this pull request Feb 28, 2023
@bors @glorv
@taiki-e @poliorcetics @c410-f3r
Merge #964
f4b09e3 
964: v0.8: Prepare for the next release r=taiki-e a=taiki-e

Changes:
- crossbeam-channel 0.5.6 -> 0.5.7
  - Improve handling of very large timeout. (#953)
- crossbeam-deque 0.8.2 -> 0.8.3
  - Add `Stealer::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
  - Add `Injector::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
- crossbeam-epoch 0.9.13 -> 0.9.14
  - Update `memoffset` to 0.8. (#955)
- crossbeam-utils 0.8.14 -> 0.8.15
  - Add `#[clippy::has_significant_drop]` to `ShardedLock{Read,Write}Guard`. (#958)
  - Improve handling of very large timeout. (#953)
  - Soft-deprecate `thread::scope()` in favor of the more efficient `std::thread::scope` that stabilized on Rust 1.63. (#954)

Backports:
- #903
- #936
- #953
- #954
- #955
- #958

Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Co-authored-by: Alexis (Poliorcetics) Bourget <alexis.bourget@gmail.com>
Co-authored-by: Caio <c410.f3r@gmail.com>
bors bot added a commit that referenced this pull request Feb 28, 2023
@bors @glorv
@taiki-e @poliorcetics @c410-f3r
Merge #964
721382b 
964: v0.8: Prepare for the next release r=taiki-e a=taiki-e

Changes:
- crossbeam-channel 0.5.6 -> 0.5.7
  - Improve handling of very large timeout. (#953)
- crossbeam-deque 0.8.2 -> 0.8.3
  - Add `Stealer::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
  - Add `Injector::{steal_batch_with_limit, steal_batch_with_limit_and_pop}` methods. (#903)
- crossbeam-epoch 0.9.13 -> 0.9.14
  - Update `memoffset` to 0.8. (#955)
- crossbeam-utils 0.8.14 -> 0.8.15
  - Add `#[clippy::has_significant_drop]` to `ShardedLock{Read,Write}Guard`. (#958)
  - Improve handling of very large timeout. (#953)
  - Soft-deprecate `thread::scope()` in favor of the more efficient `std::thread::scope` that stabilized on Rust 1.63. (#954)

Backports:
- #903
- #936
- #953
- #954
- #955
- #958

Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Co-authored-by: Alexis (Poliorcetics) Bourget <alexis.bourget@gmail.com>
Co-authored-by: Caio <c410.f3r@gmail.com>
@taiki-e
Copy link
Member

taiki-e commented Feb 28, 2023

Published in crossbeam-deque 0.8.3.

@glorv glorv deleted the steal-with-limit branch February 28, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glorv @taiki-e @BusyJay