Get realpath for ZipArchive
#11636
Merged
Get realpath for ZipArchive
#11636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure the appropriate fix here for PHPStan as checking for |
|
I suggest using |
|
Haha, looks like PHPStan doesn't like short ternary. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a few open issues, notably #10099, and the fix commented by @Seldaek resolved the issue. However, it has yet to be PR'd since Satis is now replaced by Private Packagist.
Nonetheless, here is the PR to resolve the issue where the archive paths are incorrect due to
ZipArchive::archivenot using therealpath(). Notably on MacOS wheresys_get_temp_dir()returns a symlinked path. This change is inline withPharArchive::archiveas it usesrealpath()already.There are other instances in the codebase which use
sys_get_temp_dir(). However, since they are only used for storage, and not pathing information, I don't believe they require changes.