Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium-cli/sysdump: add tetragon helm information #36749

Merged
merged 1 commit into from
Jan 15, 2025
Merged

cilium-cli/sysdump: add tetragon helm information #36749

merged 1 commit into from
Jan 15, 2025

Conversation

f1ko
Copy link
Contributor

@f1ko f1ko commented Dec 20, 2024

With this change cilium sysdump is going to create the following new files:

  • tetragon-helm-metadata-<ts>.yaml
  • tetragon-helm-values-<ts>.yaml

Creating a minimal cluster with Tetragon for testing purposes:

cat <<EOF > kind-config.yaml
apiVersion: kind.x-k8s.io/v1alpha4
kind: Cluster
name: cli
nodes:
  - role: control-plane
    extraMounts:
      - hostPath: /proc
        containerPath: /procHost
EOF
kind create cluster --config kind-config.yaml
EXTRA_HELM_FLAGS=(--set tetragon.hostProcPath=/procHost)

helm repo add cilium https://helm.cilium.io
helm repo update
helm install tetragon ${EXTRA_HELM_FLAGS[@]} cilium/tetragon -n kube-system
kubectl rollout status -n kube-system ds/tetragon -w

Release notes:

Cilium CLI now captures Tetragon helm data when performing `cilium sysdump`.

@f1ko f1ko requested a review from a team as a code owner December 20, 2024 17:10
@f1ko f1ko requested a review from squeed December 20, 2024 17:10
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 20, 2024
@github-actions github-actions bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Dec 20, 2024
@f1ko
cilium-cli/sysdump: add tetragon helm information
c578001 
With this change `cilium sysdump` is going to create the following new files:
- `tetragon-helm-metadata-<ts>.yaml`
- `tetragon-helm-values-<ts>.yaml`

Signed-off-by: Filip Nikolic <oss.filipn@gmail.com>
@f1ko f1ko force-pushed the sysdump-tetragon-helm branch from 8aaf5a5 to c578001 Compare January 7, 2025 11:05
@squeed squeed added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jan 9, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 9, 2025
@squeed
Copy link
Contributor

squeed commented Jan 9, 2025

/test

@tklauser tklauser enabled auto-merge January 15, 2025 12:59
@tklauser tklauser added this pull request to the merge queue Jan 15, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 15, 2025
Merged via the queue into cilium:main with commit 8fa4cbe Jan 15, 2025
62 of 63 checks passed
@f1ko f1ko deleted the sysdump-tetragon-helm branch January 21, 2025 13:03
@github-actions github-actions bot mentioned this pull request Feb 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

Assignees
No one assigned
Labels
cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f1ko @squeed @tklauser