Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows: do not fail ginkgo if unable to fetch features #36461

Merged
merged 1 commit into from
Dec 9, 2024
Merged

.github/workflows: do not fail ginkgo if unable to fetch features #36461

merged 1 commit into from
Dec 9, 2024

Conversation

aanm
Copy link
Member

@aanm aanm commented Dec 9, 2024

Fetching the features tested on the GH workflow should not be a reason to fail the workflow. Thus, we can continue on error if this step fails.

Fixes: a23106d (".github/workflows: report which features are being used in CI")

@aanm
.github/workflows: do not fail ginkgo if unable to fetch features
a5a588e 
Fetching the features tested on the GH workflow should not be a reason
to fail the workflow. Thus, we can continue on error if this step fails.

Fixes: a23106d (".github/workflows: report which features are being used in CI")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Dec 9, 2024
@aanm aanm requested review from a team as code owners December 9, 2024 13:16
@aanm aanm requested a review from brlbil December 9, 2024 13:16
@aanm
Copy link
Member Author

aanm commented Dec 9, 2024

/test

@aanm aanm enabled auto-merge December 9, 2024 13:16
@aanm aanm added this pull request to the merge queue Dec 9, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 9, 2024
Merged via the queue into main with commit 3fc2fde Dec 9, 2024
135 checks passed
@aanm aanm deleted the pr/fix-feature-failure-ssh-vm branch December 9, 2024 14:54
@aanm aanm added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 16, 2024
This was referenced Dec 16, 2024
Merged
Merged
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 16, 2024
@aanm aanm mentioned this pull request Dec 17, 2024
Merged
14 tasks
@cilium-release-bot cilium-release-bot bot mentioned this pull request Dec 18, 2024
Merged
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Dec 18, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 8, 2025
This was referenced Jan 14, 2025
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brlbil brlbil

Assignees
No one assigned
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aanm @brlbil