Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the tls:// prefix in the Hubble TLS doc #36410

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Add the tls:// prefix in the Hubble TLS doc #36410

merged 1 commit into from
Dec 9, 2024

Conversation

liyihuang
Copy link
Contributor

Just found I didn't update the prefix in the same doc in my previous PR #36118.

Double checked that page and there shouldn't any such mistake.

@liyihuang
Add the tls:// prefix in the Hubble TLS doc
d184e9b 
Add the tls:// prefix before the IP address since Hubble CLI requires
that in the current version and update the error message based on the newer version

Signed-off-by: Liyi Huang <liyi.huang@isovalent.com>
@liyihuang liyihuang requested review from a team as code owners December 5, 2024 20:09
@liyihuang liyihuang requested review from rolinh and qmonnet December 5, 2024 20:09
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 5, 2024
@qmonnet qmonnet added the release-note/misc This PR makes changes that have no direct user impact. label Dec 6, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 6, 2024
@qmonnet qmonnet added needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/hubble Impacts hubble server or relay labels Dec 6, 2024
@qmonnet
Copy link
Member

qmonnet commented Dec 6, 2024

/test

@joestringer joestringer added this pull request to the merge queue Dec 9, 2024
Merged via the queue into cilium:main with commit 0a5cd4d Dec 9, 2024
69 checks passed
@liyihuang liyihuang deleted the pr/liyihuang/add_tls_prefix_for_newer_hubble_cli branch December 14, 2024 03:11
@pippolo84 pippolo84 mentioned this pull request Dec 16, 2024
Merged
9 tasks
@pippolo84 pippolo84 added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Dec 16, 2024
@cilium-release-bot cilium-release-bot bot mentioned this pull request Dec 18, 2024
Merged
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 23, 2024
This was referenced Jan 15, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@rolinh rolinh Awaiting requested review from rolinh rolinh is a code owner automatically assigned from cilium/sig-hubble

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liyihuang @qmonnet @joestringer @pippolo84