metrics/features: remove reporting metrics' defaults by default #36298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/test |
aanm
force-pushed
the
pr/remove-defaults-from-features
branch
from
e9a6fe2 to
bd8cd18
Compare
|
/test |
aanm
force-pushed
the
pr/remove-defaults-from-features
branch
from
bd8cd18 to
8509ff6
Compare
|
/test |
Having all metrics defaults can cause certain cardinality issue for production clusters. Since the hive framework does not yet provides a way to pass a flag to enable, at runtime, the metrics defaults, we need to use a environment variable. Since, enabling defaults are not actually intended to be used by users, it's safe to reasonable to have this option to only be configurable by an environment variable. Signed-off-by: André Martins <andre@cilium.io>
When running in our CI we are interested to get to know all possible defaults of the feature metrics, this we should be running then with the defaults set. Signed-off-by: André Martins <andre@cilium.io>
The job_name needs to be defined on the workflows as we use it to create the file with all features that were detected. Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/remove-defaults-from-features
branch
from
8509ff6 to
76b8e13
Compare
aanm
changed the title
aanm
added
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
nebril
approved these changes
Dec 3, 2024
brlbil
approved these changes
Dec 3, 2024
derailed
approved these changes
Dec 3, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
aanm
added
backport-pending/1.14
This was referenced Dec 16, 2024
github-actions
bot
added
backport-done/1.16
github-actions
bot
added
backport-done/1.14
github-actions
bot
added
backport-done/1.15
This was referenced Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having all metrics defaults can cause certain cardinality issue for
production clusters. Since the hive framework does not yet provides a
way to pass a flag to enable, at runtime, the metrics defaults, we need
to use a environment variable. Since, enabling defaults are not actually
intended to be used by users, it's safe to reasonable to have this
option to only be configurable by an environment variable.