Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more features tracking in Cilium agent as prometheus metrics #36078

Merged
merged 19 commits into from
Nov 27, 2024
Merged

Add more features tracking in Cilium agent as prometheus metrics #36078

merged 19 commits into from
Nov 27, 2024

Conversation

aanm
Copy link
Member

@aanm aanm commented Nov 20, 2024 •
edited
Loading

Follow up of #35852 for more features. I've split in multiple commits so it's easier for each sig to review their section.

Note for reviewers: Review on a per-commit basis to make sure the feature of your sig is being detected correctly.

Features Checklist

  • Enable HostFirewall (@cilium/sig-datapath)
  • Enable LocalRedirectPolicy (@cilium/sig-datapath)
  • Enable Mutual Auth (@cilium/sig-servicemesh)
  • Enable Non DefaultDeny policy enforcement (@cilium/sig-policy)
  • Enable CIDRPoliciesToNodes (@cilium/sig-policy)
  • Enable encryption modes (@cilium/sig-datapath)
  • Enable KubeProxyReplacement (@cilium/sig-datapath)
  • Enable standalone north-south LB (@cilium/sig-datapath)
  • Enable BGP advertisement (@cilium/sig-bgp)
  • Enable Egress Gateway (@cilium/egress-gateway)
  • Enable bandwidth manager (@cilium/sig-datapath)
  • Enable SRv6 (@cilium/sig-datapath)
  • Enable SCTP (@cilium/sig-datapath)
  • Enable internal traffic policy (@cilium/sig-datapath)
  • Enable VTEP (@cilium/sig-datapath)
  • Enable Cilium Envoy Config (@cilium/sig-servicemesh)
  • Enable BigTCP (@cilium/sig-datapath)
  • Enable L2 announcement (@cilium/sig-datapath)
  • Enable external EnvoyProxy (@cilium/sig-servicemesh)
  • Enable dynamic node config (@cilium/sig-policy)

@aanm aanm added area/CI Continuous Integration testing issue or flake area/metrics Impacts statistics / metrics gathering, eg via Prometheus. kind/epic Features that are considered beyond amazing release-note/misc This PR makes changes that have no direct user impact. cilium-cli This PR contains changes related with cilium-cli labels Nov 20, 2024
@aanm aanm requested review from a team as code owners November 20, 2024 17:53
@aanm
Copy link
Member Author

aanm commented Nov 20, 2024

/test

@aanm aanm changed the title Add more features tracking in Cilium agent as prometheus metrics #36077 Add more features tracking in Cilium agent as prometheus metrics Nov 20, 2024
@aanm aanm force-pushed the pr/aanm/features-2 branch from ee5cd66 to 4377904 Compare November 20, 2024 20:33
@aanm
Copy link
Member Author

aanm commented Nov 20, 2024

/test

pippolo84
pippolo84 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@aanm aanm requested a review from a team November 21, 2024 10:16
doniacld
doniacld approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@doniacld doniacld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question for #sig-policy

@aanm aanm force-pushed the pr/aanm/features-2 branch from 4377904 to 8339471 Compare November 21, 2024 14:21
@aanm
Copy link
Member Author

aanm commented Nov 21, 2024

/test

@aanm aanm requested a review from pchaigno November 21, 2024 14:21
@aanm aanm force-pushed the pr/aanm/features-2 branch from 8339471 to 09a584c Compare November 21, 2024 15:11
@aanm
Copy link
Member Author

aanm commented Nov 21, 2024

/test

learnitall
learnitall approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@julianwiedmann julianwiedmann self-requested a review November 26, 2024 06:50
aanm added 4 commits November 27, 2024 09:42
@aanm
metrics/features: enable BigTCP
bfdf2fe 
Track which protocol and if BigTCP is enabled in Cilium

Signed-off-by: André Martins <andre@cilium.io>
@aanm
metrics/features: enable L2 announcement
527a5f7 
Track if L2 announcement and L2 Pod Announcement are enabled
in Cilium

Signed-off-by: André Martins <andre@cilium.io>
@aanm
metrics/features: enable external EnvoyProxy
8c3218c 
Track if Envoy Proxy is enabled in Cilium

Signed-off-by: André Martins <andre@cilium.io>
@aanm
metrics/features: enable dynamic node config
8e2b74a 
Track if Dynamic Node Config is enabled in Cilium

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm dismissed harsimran-pabla’s stale review November 27, 2024 08:43

Requested changes made.

@aanm aanm force-pushed the pr/aanm/features-2 branch from 09a584c to 8e2b74a Compare November 27, 2024 08:43
@aanm aanm enabled auto-merge November 27, 2024 08:43
@aanm
Copy link
Member Author

aanm commented Nov 27, 2024

/test

@aanm aanm added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 71fa658 Nov 27, 2024
273 checks passed
@aanm aanm deleted the pr/aanm/features-2 branch November 27, 2024 10:41
@aanm aanm added needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Nov 29, 2024
@aanm aanm added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 16, 2024
This was referenced Dec 16, 2024
Merged
Merged
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Dec 16, 2024
@aanm aanm mentioned this pull request Dec 17, 2024
Merged
14 tasks
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Dec 18, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Jan 8, 2025
This was referenced Jan 14, 2025
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianwiedmann julianwiedmann julianwiedmann left review comments

@borkmann borkmann borkmann left review comments

@doniacld doniacld doniacld approved these changes

@learnitall learnitall learnitall approved these changes

@sayboras sayboras sayboras approved these changes

@aspsk aspsk aspsk approved these changes

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@pippolo84 pippolo84 pippolo84 approved these changes

@pchaigno pchaigno Awaiting requested review from pchaigno

@harsimran-pabla harsimran-pabla Awaiting requested review from harsimran-pabla

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/metrics Impacts statistics / metrics gathering, eg via Prometheus. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. cilium-cli This PR contains changes related with cilium-cli kind/epic Features that are considered beyond amazing release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.