Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if requirements.txt exist before proceeding further inspection #285

Closed
pkesavap opened this issue Nov 15, 2021 · 2 comments · Fixed by #344
Closed

Check if requirements.txt exist before proceeding further inspection #285

pkesavap opened this issue Nov 15, 2021 · 2 comments · Fixed by #344
Labels
good first issue

Comments

@pkesavap
Copy link

Feel free to close this issue, if already implemented.
I ran pipreqs ./ to generate requirements.txt without knowing i already had one, and after about 4 minutes, pipreqs shows the warning

WARNING: requirements.txt already exists, use --force to overwrite it

Maybe we could do that check first before proceeding with other introspection?

Thanks
@pkesavap
Copy link
Author

Version:
pipreqs --version
0.4.11

clvnkhr added a commit to clvnkhr/pipreqs that referenced this issue Jan 5, 2023
@clvnkhr
resolve issue bndr#285
f97d8b9 
simply moved the check in init for requirements.txt ahead of searching for packages. Closes bndr#285. Passes tox (3.7, 3.8, 3.9, pypy3, flake8)
@clvnkhr clvnkhr mentioned this issue Jan 5, 2023
Merged
@clvnkhr
Copy link
Contributor

clvnkhr commented Jan 7, 2023 •
edited
Loading

Hi, I'm new to this but the fix was simple so I went ahead and opened a pull request. Tox passed locally but I think I need someone else in order to proceed. Please tell me if I did something wrong or if theres anything else I should do :)

alan-barzilay added a commit that referenced this issue Jan 14, 2023
@alan-barzilay
Merge pull request #344 from clvnkhr/Check-if-requirements.txt-exist-…
e5493d9 
…before-proceeding-further-inspection-#285

resolve issue #285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolve issue #285 clvnkhr/pipreqs
3 participants
@clvnkhr @alan-barzilay @pkesavap