Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated boolean dependency #597

Merged
merged 6 commits into from
Dec 22, 2024

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Dec 21, 2024

Hi! Sorry for the unexpected PR.
First of all, I want to say that I’ve been using eslint-doc-generator for a while and it has been very helpful! 😄

I noticed that when installing eslint-doc-generator, a warning about the deprecated boolean package appeared. To resolve this issue, I’ve created this PR. Most of the changes are based on the boolean package itself.

Please review the changes when you get a chance. Thank you for your time and consideration.

@bmish bmish added the bug Something isn't working label Dec 21, 2024
Copy link
Owner

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We can switch over to these functions for now.

It seems very odd that this package is deprecated without any explanation and that the source repository appears to have been deleted. Hopefully someone will republish the package in the future.

lib/boolean.ts Show resolved Hide resolved
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
@y-hsgw y-hsgw requested a review from bmish December 22, 2024 01:30
Copy link
Owner

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmish bmish merged commit 9873832 into bmish:main Dec 22, 2024
8 checks passed
@bmish bmish changed the title Fix deprecated boolean package warning Replace deprecated boolean dependency Dec 22, 2024
@y-hsgw y-hsgw deleted the refactor/remove-boolean-package branch December 22, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants