perf: Improve module transforms #16882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58188 |
JLHwung
reviewed
Oct 4, 2024
...ages/babel-plugin-transform-modules-commonjs/test/fixtures/misc/import-const-throw/output.js
Show resolved
Hide resolved
JLHwung
approved these changes
Oct 4, 2024
...ages/babel-plugin-transform-modules-commonjs/test/fixtures/misc/import-const-throw/output.js
Show resolved
Hide resolved
liuxingbaoyu
added
PR: Performance 🏃♀️
liuxingbaoyu
force-pushed
the
perf-cjs
branch
from
185e6c1 to
63f8ea8
Compare
| import { template, types as t } from "@babel/core"; | ||
| import type { NodePath, Visitor, Scope } from "@babel/core"; | ||
| import simplifyAccess from "@babel/helper-simple-access"; |
There was a problem hiding this comment.
Can you remove this from package.json?
Also (in a follow up PR) I'd like for this package to be inlined inside plugin-transform-modules-commonjs, since now it's only used there.
There was a problem hiding this comment.
Sure! I would try removing it first since it introduces an extra traversal.
liuxingbaoyu
force-pushed
the
perf-cjs
branch
from
166dbcf to
39fa5ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2The time was reduced by about 10%