Inline one-line syntax plugins #16824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57914 |
JLHwung
approved these changes
Oct 9, 2024
This was referenced Oct 21, 2024
This was referenced Oct 31, 2024
This was referenced Nov 1, 2024
This was referenced Nov 1, 2024
This was referenced Nov 2, 2024
This was referenced Nov 2, 2024
This was referenced Nov 2, 2024
This was referenced Nov 10, 2024
Open
Open
Open
This was referenced Nov 11, 2024
Open
This was referenced Nov 12, 2024
Open
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2I was looking at the install size of our packages, and I noticed that we can easily reduce it by a bit. Currently many transform plugins depend on their corresponding syntax plugin, which weight roughtly 1.4kB when compressed (size of https://registry.npmjs.org/@babel/plugin-syntax-object-rest-spread/-/plugin-syntax-object-rest-spread-7.8.3.tgz) and 2.5kB when unpacked (according to
npm view @babel/plugin-syntax-object-rest-spread).Most of those plugins can be inlined into a single line, reducing their effective size to a few bytes. This PR inlines all usages of trivial syntax plugins. I still left the current transform/syntax plugin split for syntax plugins that are non trivial, for example because they validate options or interact with other syntax plugins.