Use CBMC version 5.95.1 #1124
Merged
Use CBMC version 5.95.1 #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming CBMC version 6 release includes changes that may affect existing proofs. This PR will make sure that aws-c-common PRs are not negatively impacted by this release. After releasing CBMC version 6 we will issue a follow-up PR that will return aws-c-common to using CBMC's latest release, and will include any changes to proofs that may be necessary to support the new version.
graebm
approved these changes
Jun 19, 2024
Merged
graebm
added a commit
that referenced
this pull request
Jun 19, 2024
**Issue:** The proofs broke unexpectedly when CBMC 6.0.0 was released, since we were using "latest". We pinned the version back to 5.95.1 in a [recent PR](#1124) to get CI working again. **Description of changes:** - Upgrade to CBMC 6.0.0 - For all tools used in proofs, stop using "latest". Pin the exact version, so we're not caught off-guard by unexpected upgrades again in the future - Fix proof code to work with CBMC 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The upcoming CBMC version 6 release includes changes that may affect existing proofs. This PR will make sure that aws-c-common PRs are not negatively impacted by this release. After releasing CBMC version 6 we will issue a follow-up PR that will return aws-c-common to using CBMC's latest release, and will include any changes to proofs that may be necessary to support the new version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.