Expose XDP umem ptr #2146
Merged
Expose XDP umem ptr #2146
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contributions! Our XDP CI workflow recently stopped working so I've opened #2147 to address those issues. Once that's merged can you rebase on that? |
|
@camshaft sure |
camshaft
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Provides a method on Umem to expose the raw pointer to the memory mapped memory. This is necessary backdoor for 3rd party use, for instance to use madvise on the memory region, or to expose to other crates. Any such use would require the user to caveat it as unsafe (de-referencing a pointer)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.