Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): "no stack found in the main cloud assembly" #32839

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix(cli): "no stack found in the main cloud assembly" #32839

merged 2 commits into from
Jan 10, 2025
+0 −132

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 10, 2025

Reverts #32636

It leads to a problem in case of applications where there are no top-level stacks, but only stacks in nested stages: #32836.

Closes #32836.

@rix0rrr rix0rrr requested a review from a team as a code owner January 10, 2025 18:51
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p0 labels Jan 10, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 10, 2025 18:52
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 10, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 10, 2025
@rix0rrr rix0rrr added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Jan 10, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 10, 2025 18:54

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@rix0rrr rix0rrr changed the title revert(cli): warn of non-existent stacks in cdk destroy fix(cli): "no stack found in the main cloud assembly" Jan 10, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jan 10, 2025

If the original PR is re-rolled again, we need a test case for this situation.

@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jan 10, 2025
@mrgrain mrgrain mentioned this pull request Jan 10, 2025
Open
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 10, 2025 19:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (add7c6b) to head (224436d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #32839      +/-   ##
==========================================
- Coverage   81.52%   81.38%   -0.15%     
==========================================
  Files         222      222              
  Lines       13717    13695      -22     
  Branches     2417     2412       -5     
==========================================
- Hits        11183    11145      -38     
- Misses       2254     2271      +17     
+ Partials      280      279       -1
Flag Coverage Δ
suite.unit 81.38% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.69% <ø> (-0.29%) ⬇️
packages/aws-cdk-lib/core 82.09% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 224436d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr merged commit 3c0acce into main Jan 10, 2025
14 of 17 checks passed
@rix0rrr rix0rrr deleted the revert-32636-cdk-destroy-warn branch January 10, 2025 19:46
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p0 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdk destroy: No stack found in the main cloud assembly
3 participants
@rix0rrr @aws-cdk-automation @mrgrain