-
-
Notifications
You must be signed in to change notification settings - Fork 50.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Form should not trigger unnecessary onFieldsChange #43292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
MadCcc
approved these changes
Jun 30, 2023
size-limit report 📦
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## 4.x-stable #43292 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 450 450
Lines 8347 8347
Branches 2540 2540
============================================
Hits 8347 8347 ☔ View full report in Codecov by Sentry. |
yoyo837
approved these changes
Jun 30, 2023
This was referenced Jun 30, 2023
@hhhluke 帮忙给个重现我们排查一下。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
Same as #43290 fixes #43276 but for v4
Maybe also fix #43240
close #43249
💡 Background and solution
📝 Changelog
onFieldsChange
event even all the fields do not configrules
. And Form.List nested Form event bubble not correct.rules
时仍会错误触发onFieldsChange
事件的问题。以及嵌套 Form.List 嵌套 Form 的场景下,事件触发不正确的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 2ec80a9
Updated a script and a dependency for the package. The script
scripts/post-script.js
now supports a new deprecated version for theconch
tag. The dependencyrc-field-form
was upgraded to a newer version to fix some issues and enhance the form component.🔍 Walkthrough
🤖 Generated by Copilot at 2ec80a9
rc-field-form
dependency version to fix bugs and improve performance (link)4.24.11
to deprecated versions and provide reason related torc-field-form
bug (link)scripts/post-script.js
(link, link, link, link, link)conch
tag and log deprecation reasons inscripts/post-script.js
(link, link)