Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chips): improved image scaling in avatar #12843

Merged
merged 1 commit into from
Aug 27, 2018
Merged

fix(chips): improved image scaling in avatar #12843

merged 1 commit into from
Aug 27, 2018

Conversation

crisbeto
Copy link
Member

Along the same lines as #12660. Uses object-fit: cover to better scale the avatar image, where available.

For reference:
angular_material_-_google_chrome_2018-08-26_19-23-33
angular_material_-_google_chrome_2018-08-26_19-23-13

@crisbeto
fix(chips): improved image scaling in avatar
7fa0406 
Along the same lines as angular#12660. Uses `object-fit: cover` to better scale the avatar image, where available.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 26, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner August 26, 2018 17:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 26, 2018
jelbourn
jelbourn approved these changes Aug 26, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 26, 2018
@ngbot
Copy link

ngbot bot commented Aug 26, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit f6e787a into angular:master Aug 27, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
@crisbeto @jelbourn
fix(chips): improved image scaling in avatar (#12843)
130806b 
Along the same lines as #12660. Uses `object-fit: cover` to better scale the avatar image, where available.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot