fix(material/theming): fix not found error in the guide duplicate theming styles document #30108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sepandard
requested review from
crisbeto and
mmalerba
and removed request for
a team
Sepandard
force-pushed
the
fix-duplicate-theming-guides-docs
branch
from
a276ad1 to
08bc8e9
Compare
Sepandard
changed the title
|
Thanks for this contribution, however rather than bringing the guide back, it would be better to point to the v18 version of the doc instead: https://v18.material.angular.io/guide/duplicate-theming-styles |
Sepandard
force-pushed
the
fix-duplicate-theming-guides-docs
branch
from
08bc8e9 to
08906ec
Compare
…ming styles document point to the v18 version of the document resolves angular#30072
Sepandard
force-pushed
the
fix-duplicate-theming-guides-docs
branch
from
08906ec to
6f2158f
Compare
|
Based on your comment, I changed the warning message, pointing to the v18 version document. |
andrewseguin
approved these changes
Dec 16, 2024
|
Great thanks! |
andrewseguin
approved these changes
Dec 16, 2024
andrewseguin
added
the
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pointing to the v18 version of the document
resolves #30072