fix(core): Fix nested timer serialization #59173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePunderWoman
added
action: review
angular-robot
bot
added
area: core
There were type mismatches and or unintended any types that were preventing nested timers from accessing the delay value during hydration annotation processing.
thePunderWoman
force-pushed
the
hydrate-delay
branch
from
ab48689 to
beb314f
Compare
angular-robot
bot
added
area: core
thePunderWoman
commented
Dec 12, 2024
| @@ -484,13 +484,13 @@ function serializeHydrateTriggers( | |||
| DeferBlockTrigger.Viewport, | |||
| DeferBlockTrigger.Timer, | |||
| ]); | |||
| let triggers = []; | |||
| let triggers: (DeferBlockTrigger | SerializedTriggerDetails)[] = []; | |||
There was a problem hiding this comment.
this array was seen as any, which is why this explicit typing is needed here.
AndrewKushnir
approved these changes
Dec 12, 2024
AndrewKushnir
removed
the
action: review
thePunderWoman
added
the
action: merge
|
This PR was merged into the repository by commit cf89f14. The changes were merged into the following branches: main, 19.0.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Dec 12, 2024
There were type mismatches and or unintended any types that were preventing nested timers from accessing the delay value during hydration annotation processing. PR Close #59173
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were type mismatches and or unintended any types that were preventing nested timers from accessing the delay value during hydration annotation processing.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?